-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35524][cdc-base] Clear connections pools when reader exist. #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiabao-Sun
reviewed
Jun 5, 2024
...rc/main/java/org/apache/flink/cdc/connectors/base/source/reader/IncrementalSourceReader.java
Outdated
Show resolved
Hide resolved
ruanhang1993
reviewed
Jul 5, 2024
...ain/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/cdc/connectors/mysql/source/connection/JdbcConnectionPools.java
Outdated
Show resolved
Hide resolved
ruanhang1993
reviewed
Jul 5, 2024
...ain/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java
Outdated
Show resolved
Hide resolved
ruanhang1993
reviewed
Jul 5, 2024
...c/main/java/org/apache/flink/cdc/connectors/mysql/source/connection/JdbcConnectionPools.java
Outdated
Show resolved
Hide resolved
leonardBang
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @loserwang1024 for the contribution, could you rebase to latest master?
@ruanhang1993 Would you like to take a look again?
loserwang1024
force-pushed
the
clear-pools
branch
2 times, most recently
from
August 1, 2024 07:24
8d87136
to
be3a689
Compare
ruanhang1993
reviewed
Aug 1, 2024
...ain/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/cdc/connectors/mysql/source/connection/JdbcConnectionPools.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/cdc/connectors/mysql/source/connection/JdbcConnectionPools.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java
Outdated
Show resolved
Hide resolved
ruanhang1993
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
loserwang1024
force-pushed
the
clear-pools
branch
from
August 2, 2024 04:01
3b722ff
to
ea2acc9
Compare
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current, inJdbcConnectionPools is static instance, so the datasource pools in it won't be recycle when reader close. It will cause memory leak.