Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4991] add unit test for LogUtil #5100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

melisolmez
Copy link

Fixes #4991

Motivation
Increase test coverage

Modifications
Added new tests for LogUtil.java located https://github.com/apache/eventmesh/blob/master/eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/LogUtilTest.java

Documentation
Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

@harshithasudhakar harshithasudhakar changed the title add unit test for LogUtil [ISSUE #4991] add unit test for LogUtil Sep 7, 2024
@harshithasudhakar
Copy link
Member

Hi, please resolve the failing CI errors. To resolve the issue, you can view the test report generated during the build.

@melisolmez
Copy link
Author

hello @harshithasudhakar, I tried solve this problem but I cannot understand. There were failing tests. See the report at: file:///Users/runner/work/eventmesh/eventmesh/eventmesh-common/build/reports/tests/test/index.html when I saw this location but there is not fail test in index.html. Could you help with this problem?

@harshithasudhakar
Copy link
Member

harshithasudhakar commented Sep 8, 2024

I re-ran the build, it has passed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unit Test] Unit test For LogUtil.java
2 participants