Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve resouce management #407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yin1999
Copy link
Contributor

@yin1999 yin1999 commented Sep 30, 2024

What is the purpose of the change

improve resouce management

CheckList

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.45%. Comparing base (81f88e0) to head (742a39b).
Report is 14 commits behind head on master.

Current head 742a39b differs from pull request most recent head 33ea442

Please upload reports for the commit 33ea442 to get more accurate results.

Files with missing lines Patch % Lines
pkg/plugins/resources/traditional/store.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   33.46%   33.45%   -0.01%     
==========================================
  Files         163      163              
  Lines        9568     9570       +2     
  Branches       41       41              
==========================================
  Hits         3202     3202              
- Misses       6020     6022       +2     
  Partials      346      346              
Flag Coverage Δ
33.45% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants