Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/UI/metrics #112

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Feature/UI/metrics #112

merged 2 commits into from
Dec 18, 2023

Conversation

Helltab
Copy link
Contributor

@Helltab Helltab commented Dec 16, 2023

fix this #107
image

 Note: now is a demo url with same origin of mock api
 make sure the real grafana-url's X-Frame-Options is forbidden
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49cbe64) 48.53% compared to head (50bce21) 48.50%.

❗ Current head 50bce21 differs from pull request most recent head 759820a. Consider uploading reports for the commit 759820a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   48.53%   48.50%   -0.03%     
==========================================
  Files         149      148       -1     
  Lines        9565     9568       +3     
  Branches       41       41              
==========================================
- Hits         4642     4641       -1     
- Misses       4395     4399       +4     
  Partials      528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit ea38a28 into apache:master Dec 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants