Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Dubboctl UI update workflow #110

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

yin1999
Copy link
Contributor

@yin1999 yin1999 commented Dec 14, 2023

What is the purpose of the change

Fixes: #97.

This PR introduce the "Dubboctl UI Update" workflow which will automatically create a new PR for updating the build asset under the app/dubbo-ui folder.

The workflow's behavior statement:

  • Only create the update PR when the build is different than before.
  • When a PR changes the related content, this workflow will be triggered to run build test which ensures that the PR changes do not break the build process.
  • If the previous update PR is not merged, and the workflow is triggered by the push to the main branch, this workflow will not create a new PR but update the existing PR (whose branch is 'github-actions/dubboctl-ui-update')

How to verify this change

I've tested this workflow in my fork.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea38a28) 48.52% compared to head (1d1b93f) 48.50%.

❗ Current head 1d1b93f differs from pull request most recent head 1956754. Consider uploading reports for the commit 1956754 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   48.52%   48.50%   -0.03%     
==========================================
  Files         148      148              
  Lines        9568     9568              
  Branches       41       41              
==========================================
- Hits         4643     4641       -2     
- Misses       4397     4399       +2     
  Partials      528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +18 to +20
"resolutions": {
"jackspeak": "2.1.1"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A workround to fix the bug caused by the resolver.

@chickenlj
Copy link
Contributor

Please configure https://github.com/apache/dubbo-kubernetes/blob/master/.licenserc.yaml to skip license check of the following file:

ERROR the following files don't have a valid license header: 
ui-vue3/.nvmrc 
ERROR one or more files does not have a valid license header 
Error: Process completed with exit code 1.
``

@chickenlj chickenlj merged commit 2841b03 into apache:master Dec 19, 2023
5 checks passed
@yin1999 yin1999 deleted the ui-auto-build branch December 19, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github action for automatically building ui and submit to app/dubbo-ui on frontend resources update
3 participants