-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug](runtime-filter) send ignored rf when hash join build closed early #41667
base: master
Are you sure you want to change the base?
Conversation
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -472,10 +472,10 @@ class RuntimePredicateWrapper { | |||
const TExpr& probe_expr); | |||
|
|||
Status merge(const RuntimePredicateWrapper* wrapper) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'merge' has cognitive complexity of 74 (threshold 50) [readability-function-cognitive-complexity]
Status merge(const RuntimePredicateWrapper* wrapper) {
^
Additional context
be/src/exprs/runtime_filter.cpp:474: +1, including nesting penalty of 0, nesting level increased to 1
if (wrapper->is_ignored()) {
^
be/src/exprs/runtime_filter.cpp:480: +1
_filter_type == RuntimeFilterType::IN_OR_BLOOM_FILTER &&
^
be/src/exprs/runtime_filter.cpp:485: +1
bool can_not_merge_other = _filter_type != RuntimeFilterType::IN_OR_BLOOM_FILTER &&
^
be/src/exprs/runtime_filter.cpp:488: +1
CHECK(!can_not_merge_in_or_bloom && !can_not_merge_other)
^
be/src/exprs/runtime_filter.cpp:493: +1, including nesting penalty of 0, nesting level increased to 1
switch (_filter_type) {
^
be/src/exprs/runtime_filter.cpp:497: +2, including nesting penalty of 1, nesting level increased to 2
if (_max_in_num >= 0 && _context->hybrid_set->size() >= _max_in_num) {
^
be/src/exprs/runtime_filter.cpp:507: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_context->minmax_func->merge(wrapper->_context->minmax_func.get()));
^
be/src/common/status.h:629: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/exprs/runtime_filter.cpp:507: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_context->minmax_func->merge(wrapper->_context->minmax_func.get()));
^
be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/exprs/runtime_filter.cpp:511: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(
^
be/src/common/status.h:629: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/exprs/runtime_filter.cpp:511: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(
^
be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/exprs/runtime_filter.cpp:519: +2, including nesting penalty of 1, nesting level increased to 2
if (other_filter_type == RuntimeFilterType::IN_OR_BLOOM_FILTER) {
^
be/src/exprs/runtime_filter.cpp:523: +2, including nesting penalty of 1, nesting level increased to 2
if (real_filter_type == RuntimeFilterType::IN_FILTER) {
^
be/src/exprs/runtime_filter.cpp:527: +3, including nesting penalty of 2, nesting level increased to 3
if (other_filter_type == RuntimeFilterType::IN_FILTER) {
^
be/src/exprs/runtime_filter.cpp:529: +4, including nesting penalty of 3, nesting level increased to 4
if (_max_in_num >= 0 && _context->hybrid_set->size() >= _max_in_num) {
^
be/src/exprs/runtime_filter.cpp:531: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(_context->bloom_filter_func->init_with_fixed_length());
^
be/src/common/status.h:629: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/exprs/runtime_filter.cpp:531: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(_context->bloom_filter_func->init_with_fixed_length());
^
be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/exprs/runtime_filter.cpp:532: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(change_to_bloom_filter());
^
be/src/common/status.h:629: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/exprs/runtime_filter.cpp:532: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(change_to_bloom_filter());
^
be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/exprs/runtime_filter.cpp:534: +1, nesting level increased to 3
} else {
^
be/src/exprs/runtime_filter.cpp:537: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(change_to_bloom_filter());
^
be/src/common/status.h:629: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/exprs/runtime_filter.cpp:537: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(change_to_bloom_filter());
^
be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/exprs/runtime_filter.cpp:539: +1, nesting level increased to 2
} else {
^
be/src/exprs/runtime_filter.cpp:540: +3, including nesting penalty of 2, nesting level increased to 3
if (other_filter_type == RuntimeFilterType::IN_FILTER) {
^
be/src/exprs/runtime_filter.cpp:543: +1, nesting level increased to 3
} else {
^
be/src/exprs/runtime_filter.cpp:545: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(_context->bloom_filter_func->merge(
^
be/src/common/status.h:629: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/exprs/runtime_filter.cpp:545: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(_context->bloom_filter_func->merge(
^
be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
run buildall |
run buildall |
Proposed changes
send ignored rf when hash join build closed early