Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix](segmentload) should remove segment from segment cache if load segment failed (#41608) #41660

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

yiguolei
Copy link
Contributor

Proposed changes

cherrypick #41608

  1. If the segment load failed, it is not recoverable, should remove it from segment cache and the query will create new segment again.
  2. Could not depend on remove segment from cache during load index failed, because the call once may throw exception and the error handle logic is not reached.

Proposed changes

Issue Number: close #xxx

…d segment failed (apache#41608)

## Proposed changes

1. If the segment load failed, it is not recoverable, should remove it
from segment cache and the query will create new segment again.
2. Could not depend on remove segment from cache during load index
failed, because the call once may throw exception and the error handle
logic is not reached.

---------

Co-authored-by: yiguolei <[email protected]>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.08% (9335/25876)
Line Coverage: 27.65% (76677/277355)
Region Coverage: 26.43% (39355/148905)
Branch Coverage: 23.22% (20023/86242)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1808fc68dc8a30e31c995ac56e37f8276fed2985_1808fc68dc8a30e31c995ac56e37f8276fed2985/report/index.html

@yiguolei yiguolei merged commit f2ba1f2 into apache:branch-2.1 Oct 10, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants