Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](inverted index) Fix wrong need read data opt when enable_common_expr_pushdown is disabled #40689 #41562

Merged

Conversation

airborne12
Copy link
Member

cherry pick from #40689

…_expr_pushdown is disabled (apache#40689)

If common_expr_pushdown is disabled, we cannot guarantee that all
conditions are processed by the inverted index after refactor of apache#38908
Consider a scenario where there is a column predicate and an expression
involving the same column in the SQL query,
such as 'a < 0' and 'abs(a) > 1'.
This could potentially lead to errors.
@airborne12
Copy link
Member Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.10% (9340/25874)
Line Coverage: 27.66% (76719/277331)
Region Coverage: 26.45% (39374/148879)
Branch Coverage: 23.23% (20034/86228)
Coverage Report: http://coverage.selectdb-in.cc/coverage/be0a190156d75096746895393fa4d2add7e8ba8c_be0a190156d75096746895393fa4d2add7e8ba8c/report/index.html

@airborne12 airborne12 merged commit afb477c into apache:branch-2.1 Oct 8, 2024
20 of 22 checks passed
@airborne12 airborne12 deleted the pick_40689_to_origin_branch-2.1 branch October 8, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants