Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor](exec) refactor schema scanner del unless code #41540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Refactor](exec) refactor schema scanner del unless code #41540

wants to merge 1 commit into from
+6 −115

Conversation

HappenLee
Copy link
Contributor

Proposed changes

refactor schema scanner del unless code

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@HappenLee
Copy link
Contributor Author

run buildall

@HappenLee
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/exec/schema_scanner.h Show resolved Hide resolved
@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9635/25837)
Line Coverage: 28.68% (79885/278585)
Region Coverage: 28.10% (41315/147052)
Branch Coverage: 24.71% (21036/85126)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2c852a8763e13ccea577683d7d821fb9b46bcd90_2c852a8763e13ccea577683d7d821fb9b46bcd90/report/index.html

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Oct 10, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.24% (9643/25892)
Line Coverage: 28.56% (79987/280098)
Region Coverage: 27.99% (41342/147728)
Branch Coverage: 24.60% (21051/85582)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0c5eebcb5283ac02df160e203bd0362a6dd1e9b3_0c5eebcb5283ac02df160e203bd0362a6dd1e9b3/report/index.html

yiguolei
yiguolei approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HappenLee @doris-robot @BiteTheDDDDt @yiguolei