Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compile](minor) Fix unsafe type conversion #41534

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[compile](minor) Fix unsafe type conversion #41534

merged 2 commits into from
Oct 8, 2024

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Oct 8, 2024 •
edited
Loading

Proposed changes

img_v3_02ff_efb64d0d-9415-4612-b16b-34e9237ef5cg

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (9631/25832)
Line Coverage: 28.67% (79864/278576)
Region Coverage: 28.11% (41295/146927)
Branch Coverage: 24.73% (21043/85084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d33529e16cf8d3be2dd4392fc40bcfb5b4f1abba_d33529e16cf8d3be2dd4392fc40bcfb5b4f1abba/report/index.html

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9632/25832)
Line Coverage: 28.68% (79890/278577)
Region Coverage: 28.10% (41293/146927)
Branch Coverage: 24.73% (21040/85084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b2abb419e3c0652d99a83935104387d6e1a396e4_b2abb419e3c0652d99a83935104387d6e1a396e4/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR approved by at least one committer and no changes requested.

@Gabriel39 Gabriel39 merged commit 401be16 into apache:master Oct 8, 2024
24 of 28 checks passed
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@Gabriel39 @eldenmoon
[compile](minor) Fix unsafe type conversion (apache#41534)
8cf0276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@Mryange Mryange Mryange approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel39 @doris-robot @BiteTheDDDDt @Mryange