Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exec](mem) Reduce the memory usage during JOIN operations #41388

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[Exec](mem) Reduce the memory usage during JOIN operations #41388

merged 2 commits into from
Oct 8, 2024

Conversation

HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Sep 27, 2024 •
edited
Loading

Proposed changes

select t1.a from t1, t2 where t1.a = t2.a

Before:

38G

After:

30.8G

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.30% (9627/25813)
Line Coverage: 28.69% (79665/277636)
Region Coverage: 28.13% (41202/146450)
Branch Coverage: 24.75% (20978/84764)
Coverage Report: http://coverage.selectdb-in.cc/coverage/040a75a7a00cfdd7e235aaad233cb0018b59b62f_040a75a7a00cfdd7e235aaad233cb0018b59b62f/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.30% (9627/25813)
Line Coverage: 28.69% (79674/277693)
Region Coverage: 28.13% (41207/146496)
Branch Coverage: 24.74% (20984/84806)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9ce660e9297df01e70e74b74aca2fbc7b6590eee_9ce660e9297df01e70e74b74aca2fbc7b6590eee/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9626/25813)
Line Coverage: 28.69% (79669/277693)
Region Coverage: 28.13% (41212/146496)
Branch Coverage: 24.74% (20981/84806)
Coverage Report: http://coverage.selectdb-in.cc/coverage/540230043294a88bbc8ba0ca4b73fa8a83496c65_540230043294a88bbc8ba0ca4b73fa8a83496c65/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (9624/25817)
Line Coverage: 28.68% (79677/277810)
Region Coverage: 28.11% (41190/146551)
Branch Coverage: 24.72% (20973/84834)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b29300fa369937dc71db152a7b6c9ed712335a77_b29300fa369937dc71db152a7b6c9ed712335a77/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.31% (9629/25807)
Line Coverage: 28.68% (79828/278335)
Region Coverage: 28.12% (41275/146769)
Branch Coverage: 24.75% (21031/84990)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ec05b3e178271e935cbe723d888052b17f266de6_ec05b3e178271e935cbe723d888052b17f266de6/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9631/25807)
Line Coverage: 28.69% (79867/278342)
Region Coverage: 28.14% (41307/146779)
Branch Coverage: 24.76% (21047/85002)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5d085ea94ed3d03d49fe69ec7565597aae981d6f_5d085ea94ed3d03d49fe69ec7565597aae981d6f/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9631/25807)
Line Coverage: 28.69% (79850/278346)
Region Coverage: 28.14% (41298/146781)
Branch Coverage: 24.75% (21039/85004)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea29138d0864a29ff7b9a1466cca396b5ccb3227_ea29138d0864a29ff7b9a1466cca396b5ccb3227/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9631/25807)
Line Coverage: 28.69% (79856/278346)
Region Coverage: 28.13% (41292/146783)
Branch Coverage: 24.76% (21044/85006)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c9e810180f0565b0f8071e00290870c8d2421e9c_c9e810180f0565b0f8071e00290870c8d2421e9c/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.31% (9630/25808)
Line Coverage: 28.70% (79886/278349)
Region Coverage: 28.14% (41302/146784)
Branch Coverage: 24.75% (21042/85006)
Coverage Report: http://coverage.selectdb-in.cc/coverage/074a27943d4d5161cc690a9fee5150bd9da82deb_074a27943d4d5161cc690a9fee5150bd9da82deb/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9631/25808)
Line Coverage: 28.70% (79889/278349)
Region Coverage: 28.13% (41292/146784)
Branch Coverage: 24.75% (21041/85006)
Coverage Report: http://coverage.selectdb-in.cc/coverage/14daaed84ca54679765c38d4f380325bd73175dd_14daaed84ca54679765c38d4f380325bd73175dd/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9630/25807)
Line Coverage: 28.70% (79882/278345)
Region Coverage: 28.13% (41291/146783)
Branch Coverage: 24.75% (21039/85006)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9d0cde03fc419e0822a59c0cef46037c31fdc844_9d0cde03fc419e0822a59c0cef46037c31fdc844/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.31% (9628/25806)
Line Coverage: 28.68% (79837/278342)
Region Coverage: 28.13% (41282/146780)
Branch Coverage: 24.75% (21040/85004)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2e8d1fb20605add4955073dfa75bb059f7fb9062_2e8d1fb20605add4955073dfa75bb059f7fb9062/report/index.html

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9631/25806)
Line Coverage: 28.69% (79851/278342)
Region Coverage: 28.14% (41302/146780)
Branch Coverage: 24.76% (21045/85004)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b69572cb7474de39f71e17fcd9dc03b61f7b45cb_b69572cb7474de39f71e17fcd9dc03b61f7b45cb/report/index.html

@HappenLee HappenLee changed the title save hash mem code [Exec](mem) Reduce the memory usage during JOIN operations Oct 2, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

PR approved by anyone and no changes requested.

@zhangstar333 zhangstar333 merged commit 1fc6b35 into apache:master Oct 8, 2024
25 of 30 checks passed
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@HappenLee @eldenmoon
[Exec](mem) Reduce the memory usage during JOIN operations (apache#41388
f1c0558 
)

## Proposed changes
```
select t1.a from t1, t2 where t1.a = t2.a
```
Before:
```
38G 
```

After:
```
30.8G
```

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HappenLee @doris-robot @BiteTheDDDDt @zhangstar333