Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick](branch-21) fix tablet sink shuffle without project not match the output tuple (#40299)(#41293) #41327

Open
wants to merge 2 commits into
base: branch-2.1
Choose a base branch
from
Open

[cherry-pick](branch-21) fix tablet sink shuffle without project not match the output tuple (#40299)(#41293) #41327

wants to merge 2 commits into from
+143 −6

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

cherry-pick from master (#40299)(#41293)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.15% (9345/25853)
Line Coverage: 27.68% (76787/277454)
Region Coverage: 26.43% (39399/149066)
Branch Coverage: 23.23% (20061/86376)
Coverage Report: http://coverage.selectdb-in.cc/coverage/379180b6d748e1e745f77a6a3d34941cf96a0b68_379180b6d748e1e745f77a6a3d34941cf96a0b68/report/index.html

@zhangstar333 @yiguolei
[Bug](exchange) fix tablet sink shuffle without project not match the…
2422119 
… output tuple (apache#40299)

```
INSERT INTO tbl_4 SELECT k1, k2, k2 FROM tbl_1;

the tbl_1 have k1,k2 columns
the tbl_4 have k1,k2,v columns
if without project expr, will be only two columns not match the output tuple.
```
the co-auther of FE code  from @starocean999
@zhangstar333 @yiguolei
[Bug](tablet-shuffle) tablet shuffle sink data should use input block…
9431202 
… rather than convert_block (apache#41293)

## Proposed changes
 the convert_block is empty firstly, after execute exprs will be filled.
 so convert_block maybe different with block.
 so when send data we still need use block.

<!--Describe your changes.-->
@yiguolei
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.08% (9340/25889)
Line Coverage: 27.65% (76726/277481)
Region Coverage: 26.44% (39385/148956)
Branch Coverage: 23.23% (20035/86264)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9431202f949f983c5d3dfeee3b93156cc5dedff6_9431202f949f983c5d3dfeee3b93156cc5dedff6/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangstar333 @doris-robot @yiguolei