[Fix](Nereids) fix append_trailing_char_if_absent function return null (#40820) #41160
+133
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
LiBinfeng-01
force-pushed
the
fix_append_2.0
branch
from
8a1a083
to
adb0649
Compare
|
run buildall |
LiBinfeng-01
force-pushed
the
fix_append_2.0
branch
from
adb0649
to
2be0f8f
Compare
|
run buildall |
1 similar comment
|
run buildall |
morrySnow
requested changes
Oct 10, 2024
| @@ -805,7 +807,13 @@ public class SessionVariable implements Serializable, Writable { | |||
| private boolean enableJoinReorderBasedCost = false; | |||
|
|
|||
| @VariableMgr.VarAttr(name = ENABLE_FOLD_CONSTANT_BY_BE, fuzzy = true) | |||
| <<<<<<< HEAD | |||
morrySnow
changed the title
…35584) which force skip constant fold in nereids. make it easier for test, especially for SqlLogic platform
LiBinfeng-01
force-pushed
the
fix_append_2.0
branch
from
ff43dad
to
2a18c64
Compare
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick： #40820
example: select append_trailing_char_if_absent('it','a') would return null in original design, it can not return null when folding constant on fe any time