-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](struct) Add a new syntax for struct constructor #41118
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
run buildall |
run buildall |
run buildall |
run p0 |
@@ -1555,7 +1555,7 @@ functionCallExpression | |||
: functionIdentifier | |||
LEFT_PAREN ( | |||
(DISTINCT|ALL)? | |||
arguments+=expression (COMMA arguments+=expression)* | |||
arguments+=argumentExpression (COMMA arguments+=argumentExpression)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- namedExpression contains expression, so use namedExpression directly is ok
- i think any other function should throw exception explicitly, such as abs(a as b). so we should specific
struct
function and should not change any other function 's syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Proposed changes
Add a new syntax for struct construct.
STRUCT( expr1 [AS field_name] [, ... ])
e.g.