Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](memory) Allows to enable memory tracker accuracy detection via Config #40714

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

xinyiZzz
Copy link
Contributor

add crash_in_memory_tracker_inaccurate, If memory tracker value is inaccurate, BE will crash. usually used in test environments, default value is false.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40145 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7006176239ce1b0fd712490b4027f1be4485d303, data reload: false

------ Round 1 ----------------------------------
q1	17626	4796	4226	4226
q2	2041	188	186	186
q3	10621	1322	1408	1322
q4	10282	982	1055	982
q5	7736	3203	3166	3166
q6	229	141	139	139
q7	1045	641	638	638
q8	9454	2020	2062	2020
q9	6834	6349	6350	6349
q10	7029	2516	2470	2470
q11	445	251	252	251
q12	408	226	229	226
q13	17757	3070	3039	3039
q14	290	251	253	251
q15	561	506	498	498
q16	543	429	425	425
q17	1005	944	973	944
q18	7475	6962	6908	6908
q19	1379	1253	1238	1238
q20	629	332	322	322
q21	3940	3563	3546	3546
q22	1093	1018	999	999
Total cold run time: 108422 ms
Total hot run time: 40145 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4246	4204	4168	4168
q2	350	235	233	233
q3	2906	2924	2942	2924
q4	1932	1967	2100	1967
q5	5786	5680	5852	5680
q6	221	139	143	139
q7	2159	1762	1766	1762
q8	3344	3438	3478	3438
q9	8917	8859	8930	8859
q10	3534	3657	3642	3642
q11	574	478	471	471
q12	829	627	621	621
q13	8593	3261	3236	3236
q14	336	285	280	280
q15	571	509	509	509
q16	515	473	478	473
q17	1830	1747	1760	1747
q18	8531	8112	8021	8021
q19	1797	1775	1773	1773
q20	2144	1893	1876	1876
q21	6001	5832	5922	5832
q22	1081	1013	1006	1006
Total cold run time: 66197 ms
Total hot run time: 58657 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.90% (9456/25629)
Line Coverage: 28.25% (77775/275306)
Region Coverage: 27.65% (40154/145203)
Branch Coverage: 24.26% (20400/84092)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7006176239ce1b0fd712490b4027f1be4485d303_7006176239ce1b0fd712490b4027f1be4485d303/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 199100 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7006176239ce1b0fd712490b4027f1be4485d303, data reload: false

query1	1254	886	911	886
query2	6370	1760	1799	1760
query3	10651	3875	4016	3875
query4	55188	25575	23987	23987
query5	5100	539	528	528
query6	366	179	178	178
query7	5680	315	302	302
query8	306	226	220	220
query9	6247	2456	2455	2455
query10	407	287	278	278
query11	15868	15532	15457	15457
query12	156	103	102	102
query13	1464	414	389	389
query14	10331	7143	6772	6772
query15	216	180	184	180
query16	7071	489	451	451
query17	1162	616	582	582
query18	1903	317	314	314
query19	216	162	150	150
query20	124	119	112	112
query21	208	112	105	105
query22	4757	4578	4512	4512
query23	34608	33672	33588	33588
query24	6182	3068	3071	3068
query25	521	417	415	415
query26	611	162	162	162
query27	1562	287	287	287
query28	2786	2007	1979	1979
query29	704	431	431	431
query30	227	157	166	157
query31	954	787	769	769
query32	78	54	57	54
query33	500	313	299	299
query34	908	491	473	473
query35	875	729	723	723
query36	1046	888	911	888
query37	147	85	84	84
query38	3985	3965	3863	3863
query39	1427	1450	1397	1397
query40	209	116	117	116
query41	49	48	48	48
query42	125	102	99	99
query43	506	453	434	434
query44	1168	780	742	742
query45	201	170	167	167
query46	1103	832	824	824
query47	1999	1774	1809	1774
query48	374	291	297	291
query49	722	439	436	436
query50	940	447	443	443
query51	6981	6921	6874	6874
query52	100	89	88	88
query53	262	196	180	180
query54	567	462	465	462
query55	77	76	74	74
query56	275	262	283	262
query57	1250	1087	1074	1074
query58	227	236	247	236
query59	2837	2591	2540	2540
query60	292	277	275	275
query61	121	103	105	103
query62	802	669	671	669
query63	225	182	187	182
query64	1599	669	729	669
query65	3209	3172	3158	3158
query66	677	348	344	344
query67	15930	15663	15442	15442
query68	2032	582	596	582
query69	424	273	280	273
query70	1190	1103	1112	1103
query71	350	282	280	280
query72	6181	4067	4006	4006
query73	757	333	333	333
query74	9458	8999	9024	8999
query75	3407	2701	2728	2701
query76	1361	1339	1295	1295
query77	544	322	308	308
query78	9893	9359	9791	9359
query79	1159	890	862	862
query80	1087	854	826	826
query81	544	268	271	268
query82	990	262	266	262
query83	194	193	189	189
query84	280	107	105	105
query85	728	455	402	402
query86	343	319	322	319
query87	4381	4339	4346	4339
query88	4248	4162	4165	4162
query89	395	370	376	370
query90	1897	323	312	312
query91	130	125	123	123
query92	79	75	76	75
query93	1168	1063	1053	1053
query94	791	402	374	374
query95	481	432	438	432
query96	479	476	477	476
query97	3156	3144	3162	3144
query98	237	232	228	228
query99	1692	1302	1310	1302
Total cold run time: 295049 ms
Total hot run time: 199100 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7006176239ce1b0fd712490b4027f1be4485d303, data reload: false

query1	0.05	0.05	0.04
query2	0.07	0.04	0.04
query3	0.23	0.06	0.05
query4	1.66	0.06	0.06
query5	0.50	0.50	0.50
query6	1.12	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.56	0.50	0.52
query10	0.56	0.60	0.56
query11	0.16	0.14	0.13
query12	0.15	0.12	0.13
query13	0.63	0.60	0.60
query14	1.51	1.48	1.45
query15	0.91	0.88	0.86
query16	0.36	0.35	0.37
query17	1.04	1.03	1.01
query18	0.16	0.16	0.16
query19	1.89	1.87	1.82
query20	0.01	0.00	0.01
query21	15.40	0.65	0.66
query22	4.18	7.57	1.09
query23	17.87	1.44	1.34
query24	2.28	0.22	0.22
query25	0.18	0.08	0.08
query26	0.28	0.19	0.17
query27	0.09	0.07	0.08
query28	13.16	1.01	0.97
query29	12.52	3.34	3.32
query30	0.24	0.06	0.05
query31	2.86	0.43	0.41
query32	3.23	0.49	0.49
query33	3.03	3.05	3.10
query34	15.74	4.30	4.34
query35	4.37	4.36	4.33
query36	0.69	0.48	0.50
query37	0.19	0.17	0.16
query38	0.17	0.16	0.14
query39	0.05	0.04	0.04
query40	0.18	0.13	0.14
query41	0.10	0.06	0.05
query42	0.06	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 108.56 s
Total hot run time: 30.64 s

yiguolei
yiguolei previously approved these changes Sep 12, 2024
@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 43455 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a933b0cb1fc7d57441bde3ed05b3b9e406115034, data reload: false

------ Round 1 ----------------------------------
q1	17992	7434	7341	7341
q2	2997	186	208	186
q3	10445	1370	1419	1370
q4	10151	997	1075	997
q5	7718	3233	3399	3233
q6	243	156	157	156
q7	1053	636	640	636
q8	9447	2052	2066	2052
q9	6869	6322	6314	6314
q10	7025	2537	2535	2535
q11	436	250	262	250
q12	417	240	234	234
q13	17762	3038	3049	3038
q14	283	255	270	255
q15	595	555	529	529
q16	526	423	427	423
q17	987	967	957	957
q18	7554	6821	6848	6821
q19	1390	1245	1234	1234
q20	622	354	324	324
q21	3947	3557	3541	3541
q22	1108	1031	1029	1029
Total cold run time: 109567 ms
Total hot run time: 43455 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7210	7190	7153	7153
q2	342	229	239	229
q3	2992	2931	2932	2931
q4	1985	1965	1943	1943
q5	5509	5454	5397	5397
q6	237	147	148	147
q7	2068	1710	1684	1684
q8	3271	3378	3340	3340
q9	8470	8426	8501	8426
q10	3426	3454	3465	3454
q11	592	468	472	468
q12	797	628	585	585
q13	6280	3052	3027	3027
q14	311	276	277	276
q15	564	517	514	514
q16	489	443	447	443
q17	1767	1726	1718	1718
q18	8019	7782	7461	7461
q19	1745	1709	1694	1694
q20	2066	1814	1836	1814
q21	5642	5597	5502	5502
q22	1088	1014	1029	1014
Total cold run time: 64870 ms
Total hot run time: 59220 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195778 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a933b0cb1fc7d57441bde3ed05b3b9e406115034, data reload: false

query1	927	383	379	379
query2	6502	1800	1725	1725
query3	6659	213	216	213
query4	25809	24214	23815	23815
query5	5208	548	528	528
query6	259	173	178	173
query7	4589	302	306	302
query8	279	224	213	213
query9	8468	2626	2622	2622
query10	446	317	284	284
query11	16087	15520	15603	15520
query12	164	98	101	98
query13	1708	400	385	385
query14	10795	6910	6968	6910
query15	220	178	178	178
query16	7580	498	454	454
query17	1417	582	576	576
query18	1881	290	291	290
query19	198	154	149	149
query20	120	117	114	114
query21	210	106	104	104
query22	4748	4191	4135	4135
query23	34571	33895	34009	33895
query24	10165	3238	3081	3081
query25	686	412	424	412
query26	1359	163	163	163
query27	2849	283	295	283
query28	6848	2125	2097	2097
query29	959	427	437	427
query30	295	163	156	156
query31	1003	802	769	769
query32	106	57	63	57
query33	746	320	295	295
query34	896	482	499	482
query35	868	740	738	738
query36	1071	890	908	890
query37	182	86	88	86
query38	4007	3929	3914	3914
query39	1454	1412	1429	1412
query40	288	120	117	117
query41	53	50	53	50
query42	130	98	102	98
query43	486	447	448	447
query44	1285	807	791	791
query45	198	169	172	169
query46	1129	866	881	866
query47	1935	1794	1813	1794
query48	382	293	293	293
query49	1135	461	459	459
query50	917	432	447	432
query51	7180	6904	6999	6904
query52	103	92	90	90
query53	268	192	187	187
query54	821	467	481	467
query55	82	77	77	77
query56	289	280	280	280
query57	1203	1081	1073	1073
query58	255	250	245	245
query59	2962	2590	2795	2590
query60	311	293	281	281
query61	125	119	123	119
query62	1019	661	691	661
query63	225	184	191	184
query64	5376	681	696	681
query65	3284	3187	3213	3187
query66	1416	311	321	311
query67	16034	15607	15626	15607
query68	3203	884	865	865
query69	439	327	331	327
query70	1172	1125	1148	1125
query71	361	356	348	348
query72	5866	3396	3461	3396
query73	600	596	591	591
query74	9100	9154	9085	9085
query75	3164	3029	3031	3029
query76	1917	879	873	873
query77	431	398	416	398
query78	9432	9277	9336	9277
query79	917	889	894	889
query80	864	841	832	832
query81	446	258	259	258
query82	276	273	268	268
query83	190	188	198	188
query84	239	107	107	107
query85	653	412	400	400
query86	307	316	331	316
query87	4424	4435	4537	4435
query88	4211	4153	4132	4132
query89	388	383	385	383
query90	1281	325	321	321
query91	125	125	179	125
query92	79	77	74	74
query93	1062	1091	1063	1063
query94	622	356	379	356
query95	464	427	412	412
query96	473	485	481	481
query97	3119	3135	3123	3123
query98	224	227	229	227
query99	1547	1324	1290	1290
Total cold run time: 278826 ms
Total hot run time: 195778 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a933b0cb1fc7d57441bde3ed05b3b9e406115034, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.04	0.05
query4	1.69	0.06	0.06
query5	0.51	0.50	0.50
query6	1.14	0.73	0.73
query7	0.01	0.01	0.01
query8	0.06	0.05	0.04
query9	0.56	0.52	0.50
query10	0.57	0.59	0.59
query11	0.17	0.12	0.12
query12	0.15	0.12	0.12
query13	0.62	0.61	0.61
query14	1.39	1.47	1.45
query15	0.91	0.88	0.89
query16	0.36	0.37	0.36
query17	1.02	1.02	1.02
query18	0.22	0.21	0.20
query19	1.92	1.83	1.83
query20	0.01	0.01	0.01
query21	15.40	0.69	0.69
query22	4.40	7.14	1.37
query23	18.34	1.23	1.27
query24	2.45	0.22	0.21
query25	0.18	0.08	0.08
query26	0.30	0.18	0.18
query27	0.08	0.08	0.08
query28	13.18	1.13	1.09
query29	12.55	3.40	3.38
query30	0.24	0.06	0.06
query31	2.88	0.42	0.41
query32	3.23	0.50	0.49
query33	3.04	3.05	3.07
query34	15.43	4.31	4.33
query35	4.35	4.36	4.41
query36	0.70	0.50	0.48
query37	0.19	0.17	0.16
query38	0.17	0.16	0.15
query39	0.04	0.04	0.04
query40	0.17	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.05	0.04
Total cold run time: 109.18 s
Total hot run time: 31.22 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.89% (9462/25648)
Line Coverage: 28.25% (77782/275353)
Region Coverage: 27.65% (40165/145238)
Branch Coverage: 24.27% (20410/84108)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a933b0cb1fc7d57441bde3ed05b3b9e406115034_a933b0cb1fc7d57441bde3ed05b3b9e406115034/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 13, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit e1db945 into apache:master Sep 13, 2024
23 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants