Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test]check schema change mem return 0 #40675

Closed
wants to merge 1 commit into from
Closed

[test]check schema change mem return 0 #40675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions be/src/agent/task_worker_pool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,20 @@ void alter_tablet(StorageEngine& engine, const TAgentTaskRequest& agent_task_req
std::to_string(agent_task_req.alter_tablet_req_v2.base_tablet_id),
std::to_string(agent_task_req.alter_tablet_req_v2.new_tablet_id),
engine.memory_limitation_bytes_per_thread_for_schema_change()));

Defer defer {[&]() {
int64_t mem_consume = mem_tracker->consumption();
if (mem_consume != 0) {
std::string mem_tracker_msg = fmt::format(
" Limit={}, CurrUsed={}, "
"PeakUsed={}",
MemTracker::print_bytes(mem_tracker->limit()),
MemTracker::print_bytes(mem_consume),
MemTracker::print_bytes(mem_tracker->peak_consumption()));
LOG(FATAL) << "schema change mem not return zero, " << mem_tracker_msg;
}
}};

SCOPED_ATTACH_TASK(mem_tracker);
DorisMetrics::instance()->create_rollup_requests_total->increment(1);
Status res = Status::OK();
Expand Down Expand Up @@ -270,6 +284,20 @@ void alter_cloud_tablet(CloudStorageEngine& engine, const TAgentTaskRequest& age
std::to_string(agent_task_req.alter_tablet_req_v2.base_tablet_id),
std::to_string(agent_task_req.alter_tablet_req_v2.new_tablet_id),
engine.memory_limitation_bytes_per_thread_for_schema_change()));

Defer defer {[&]() {
int64_t mem_consume = mem_tracker->consumption();
if (mem_consume != 0) {
std::string mem_tracker_msg = fmt::format(
" Limit={}, CurrUsed={}, "
"PeakUsed={}",
MemTracker::print_bytes(mem_tracker->limit()),
MemTracker::print_bytes(mem_consume),
MemTracker::print_bytes(mem_tracker->peak_consumption()));
LOG(FATAL) << "cloud schema change mem not return zero, " << mem_tracker_msg;
}
}};

SCOPED_ATTACH_TASK(mem_tracker);
DorisMetrics::instance()->create_rollup_requests_total->increment(1);
Status res = Status::OK();
Expand Down
Loading