[fix](mtmv) Fix duplicate column name not check when create materialized view #40658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 38377 ms |
TPC-DS: Total hot run time: 197451 ms |
ClickBench: Total hot run time: 31.71 s |
morrySnow
previously approved these changes
Sep 11, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
morrySnow
reviewed
Sep 11, 2024
| public void validateColumns(List<ColumnDefinition> columns) throws UserException { | ||
| Set<String> colSets = Sets.newTreeSet(String.CASE_INSENSITIVE_ORDER); | ||
| for (ColumnDefinition col : columns) { | ||
| if (!colSets.add(col.getName())) { |
There was a problem hiding this comment.
do we check invalid character in column name?
There was a problem hiding this comment.
Yeah,already have the logic to check invalid caracter in column name, and move the check invalid caracter logic to method validateColumns
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 41634 ms |
TPC-DS: Total hot run time: 194119 ms |
ClickBench: Total hot run time: 31.91 s |
seawinde
force-pushed
the
fix_create_mtmv_name_duplicate
branch
from
297e378
to
30db4dd
Compare
|
run buildall |
TPC-H: Total hot run time: 41480 ms |
TPC-DS: Total hot run time: 193722 ms |
ClickBench: Total hot run time: 31.74 s |
morrySnow
reviewed
Sep 19, 2024
regression-test/suites/mtmv_p0/same_column_name_check/same_column_name_check.groovy
Outdated
Show resolved
Hide resolved
|
run buildall |
morrySnow
approved these changes
Sep 19, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
TPC-H: Total hot run time: 41620 ms |
TPC-DS: Total hot run time: 196034 ms |
ClickBench: Total hot run time: 32.32 s |
starocean999
approved these changes
Sep 20, 2024
dataroaring
pushed a commit
that referenced
this pull request
Sep 26, 2024
…zed view (#40658) ## Proposed changes This is brought by #26146 If create materialized view as following, Should fail, because has the duplicated column name `o_orderdatE` and `o_orderdate`. But now can create materialized view successfully. the pr fix this. ```sql CREATE MATERIALIZED VIEW mv_1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL partition by(o_orderdate) DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select o_orderdatE, o_shippriority, o_comment, o_orderdate, sum(o_totalprice) as sum_total, max(o_totalpricE) as max_total, min(o_totalprice) as min_total, count(*) as count_all, bitmap_union(to_bitmap(case when o_shippriority > 1 and o_orderkey IN (1, 3) then o_custkey else null end)) cnt_1, bitmap_union(to_bitmap(case when o_shippriority > 2 and o_orderkey IN (2) then o_custkey else null end)) as cnt_2 from (select * from orders) as t1 group by o_orderdatE, o_shippriority, o_comment, o_orderdate; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is brought by #26146
If create materialized view as following, Should fail, because has the duplicated column name
o_orderdatEando_orderdate. But now can create materialized view successfully. the pr fix this.CREATE MATERIALIZED VIEW mv_1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL partition by(o_orderdate) DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select o_orderdatE, o_shippriority, o_comment, o_orderdate, sum(o_totalprice) as sum_total, max(o_totalpricE) as max_total, min(o_totalprice) as min_total, count(*) as count_all, bitmap_union(to_bitmap(case when o_shippriority > 1 and o_orderkey IN (1, 3) then o_custkey else null end)) cnt_1, bitmap_union(to_bitmap(case when o_shippriority > 2 and o_orderkey IN (2) then o_custkey else null end)) as cnt_2 from (select * from orders) as t1 group by o_orderdatE, o_shippriority, o_comment, o_orderdate;