Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore](runtime-filter) avoid dcheck fail when rf merge failed (#39172) #40409

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

pick from #39172

## Proposed changes
 avoid dcheck fail when rf merge failed
there is a difference in the logic of calculating bf size between 2.1
and 3.0, so the merge will fail
this pr is to prevent core dump caused by dcheck failure during rolling
upgrade.
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@yiguolei
Copy link
Contributor

yiguolei commented Sep 5, 2024

skip buildall

1 similar comment
@hello-stephen
Copy link
Contributor

skip buildall

@hello-stephen hello-stephen merged commit d9fa59b into branch-2.1 Sep 5, 2024
27 of 30 checks passed
@hello-stephen hello-stephen deleted the cp_0905_2 branch September 5, 2024 06:50
Copy link
Contributor

github-actions bot commented Sep 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants