Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](aes_encrypt) support GCM mode for aes_encrypt and aes_decrypt #40004

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[feature](aes_encrypt) support GCM mode for aes_encrypt and aes_decrypt #40004

merged 2 commits into from
Sep 5, 2024

Conversation

cambyzju
Copy link
Contributor

support GCM mode for aes encrypt and decrypt, like spark, clickhouse, bigquery, snowflake and so on.

Usage:

> SELECT TO_BASE64(AES_ENCRYPT_V2('Spark SQL', '1234567890abcdef', '123456789012', 'aes_128_gcm', 'Some AAD'));
+---------------------------------------------------------------------------------------+
| to_base64(aes_encrypt('Spark SQL', '***', '123456789012', 'aes_128_gcm', 'Some AAD')) |
+---------------------------------------------------------------------------------------+
| MTIzNDU2Nzg5MDEyMdXvR41sJqwZ6hnTU8FRTTtXbL8yeChIZA==                                  |
+---------------------------------------------------------------------------------------+

> SELECT AES_DECRYPT_V2(FROM_BASE64('MTIzNDU2Nzg5MDEyMdXvR41sJqwZ6hnTU8FRTTtXbL8yeChIZA=='), '1234567890abcdef', '', 'aes_128_gcm', 'Some AAD');
+------------------------------------------------------------------------------------------------------------------------+
| aes_decrypt(from_base64('MTIzNDU2Nzg5MDEyMdXvR41sJqwZ6hnTU8FRTTtXbL8yeChIZA=='), '***', '', 'aes_128_gcm', 'Some AAD') |
+------------------------------------------------------------------------------------------------------------------------+
| Spark SQL                                                                                                              |
+------------------------------------------------------------------------------------------------------------------------+

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37362 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit da2925fdf3f3ccf5b50a5da83907397b20ac6e00, data reload: false

------ Round 1 ----------------------------------
q1	17640	4582	4230	4230
q2	2014	191	170	170
q3	11652	938	1149	938
q4	10523	692	781	692
q5	7768	2809	2778	2778
q6	220	134	134	134
q7	945	616	591	591
q8	9315	2042	2051	2042
q9	6858	6487	6556	6487
q10	6997	2189	2180	2180
q11	448	241	241	241
q12	386	229	223	223
q13	18895	3074	3039	3039
q14	275	230	236	230
q15	516	481	486	481
q16	493	395	383	383
q17	953	665	768	665
q18	7292	6772	6803	6772
q19	1393	1011	1066	1011
q20	677	347	323	323
q21	3896	2759	2902	2759
q22	1110	993	1004	993
Total cold run time: 110266 ms
Total hot run time: 37362 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4330	4263	4258	4258
q2	373	275	269	269
q3	2880	2690	2625	2625
q4	1983	1615	1632	1615
q5	5525	5648	5686	5648
q6	224	136	142	136
q7	2225	1768	1820	1768
q8	3279	3422	3430	3422
q9	8725	8689	8707	8689
q10	3563	3339	3384	3339
q11	596	501	507	501
q12	844	663	669	663
q13	13845	3192	3240	3192
q14	321	287	284	284
q15	541	498	489	489
q16	530	440	440	440
q17	1849	1539	1510	1510
q18	8013	7730	7788	7730
q19	1715	1557	1638	1557
q20	2175	1903	1907	1903
q21	5747	5427	5452	5427
q22	1152	1110	1067	1067
Total cold run time: 70435 ms
Total hot run time: 56532 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193045 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit da2925fdf3f3ccf5b50a5da83907397b20ac6e00, data reload: false

query1	1257	893	858	858
query2	6292	1962	1911	1911
query3	10705	4074	3948	3948
query4	59749	25828	23217	23217
query5	5448	496	484	484
query6	417	166	168	166
query7	5768	302	293	293
query8	300	210	202	202
query9	8586	2486	2475	2475
query10	471	279	251	251
query11	18029	15098	15207	15098
query12	151	106	103	103
query13	1482	396	387	387
query14	10630	7754	7360	7360
query15	227	178	169	169
query16	7174	464	460	460
query17	1085	567	564	564
query18	1348	294	293	293
query19	297	145	152	145
query20	134	111	116	111
query21	214	106	100	100
query22	4783	4616	4634	4616
query23	33981	33822	33206	33206
query24	5924	2853	2812	2812
query25	551	407	402	402
query26	681	166	158	158
query27	1768	277	290	277
query28	3759	2074	2060	2060
query29	671	424	425	424
query30	237	156	150	150
query31	951	758	749	749
query32	73	55	56	55
query33	473	294	294	294
query34	851	478	474	474
query35	843	730	735	730
query36	1064	970	936	936
query37	141	82	78	78
query38	3961	3905	3907	3905
query39	1437	1379	1412	1379
query40	193	119	117	117
query41	46	47	45	45
query42	114	99	97	97
query43	502	478	480	478
query44	1097	748	747	747
query45	197	171	166	166
query46	1089	720	784	720
query47	1916	1821	1800	1800
query48	375	304	308	304
query49	767	450	445	445
query50	818	429	418	418
query51	7185	7041	7056	7041
query52	103	92	89	89
query53	252	182	178	178
query54	573	457	459	457
query55	79	76	81	76
query56	286	258	273	258
query57	1206	1071	1075	1071
query58	235	248	244	244
query59	2978	2973	2828	2828
query60	307	283	281	281
query61	120	121	119	119
query62	754	678	659	659
query63	218	187	187	187
query64	2995	664	655	655
query65	3227	3101	3167	3101
query66	614	335	331	331
query67	15661	15204	15334	15204
query68	4165	581	581	581
query69	414	275	278	275
query70	1145	1083	1127	1083
query71	330	271	276	271
query72	6422	4017	3979	3979
query73	756	333	332	332
query74	9133	8796	8710	8710
query75	3328	2737	2639	2639
query76	1568	1031	923	923
query77	552	330	316	316
query78	10153	9288	9161	9161
query79	1045	584	551	551
query80	800	507	497	497
query81	563	224	225	224
query82	226	136	131	131
query83	200	144	151	144
query84	268	74	78	74
query85	811	293	291	291
query86	311	302	283	283
query87	4340	4255	4389	4255
query88	3014	2384	2383	2383
query89	391	292	281	281
query90	1897	200	192	192
query91	121	102	103	102
query92	61	54	52	52
query93	1067	532	536	532
query94	712	307	292	292
query95	354	267	263	263
query96	581	273	274	273
query97	3200	3080	3073	3073
query98	213	210	201	201
query99	1547	1265	1278	1265
Total cold run time: 305508 ms
Total hot run time: 193045 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit da2925fdf3f3ccf5b50a5da83907397b20ac6e00, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.08
query5	0.51	0.50	0.52
query6	1.13	0.73	0.73
query7	0.01	0.01	0.01
query8	0.04	0.04	0.04
query9	0.54	0.48	0.47
query10	0.54	0.53	0.55
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.59	0.58
query14	0.76	0.80	0.77
query15	0.88	0.81	0.81
query16	0.38	0.38	0.37
query17	1.06	1.04	1.04
query18	0.21	0.20	0.20
query19	1.81	1.82	1.85
query20	0.01	0.01	0.01
query21	15.39	0.67	0.66
query22	4.04	7.91	1.70
query23	18.27	1.32	1.27
query24	2.06	0.23	0.22
query25	0.16	0.08	0.07
query26	0.27	0.18	0.17
query27	0.09	0.07	0.07
query28	13.25	0.99	1.01
query29	12.59	3.32	3.28
query30	0.26	0.05	0.05
query31	2.87	0.42	0.38
query32	3.24	0.47	0.47
query33	2.98	2.99	3.02
query34	17.02	4.38	4.41
query35	4.45	4.46	4.43
query36	0.66	0.50	0.52
query37	0.18	0.16	0.15
query38	0.16	0.14	0.14
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.03	0.04
Total cold run time: 109.17 s
Total hot run time: 30.52 s

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

morrySnow
morrySnow previously approved these changes Aug 29, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@cambyzju
Copy link
Contributor Author

run External

@cambyzju
Copy link
Contributor Author

run performance

zhangstar333
zhangstar333 previously approved these changes Aug 30, 2024
View reviewed changes
@cambyzju
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xinyiZzz
xinyiZzz previously approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cambyzju
Copy link
Contributor Author

cambyzju commented Sep 3, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

cambyzju commented Sep 4, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (9386/25488)
Line Coverage: 28.27% (77477/274024)
Region Coverage: 27.67% (39987/144494)
Branch Coverage: 24.31% (20341/83680)
Coverage Report: http://coverage.selectdb-in.cc/coverage/920e0615d3604bf3cd846faa8b558bf4072facc4_920e0615d3604bf3cd846faa8b558bf4072facc4/report/index.html

@cambyzju cambyzju dismissed stale reviews from morrySnow and zhangstar333 via 6a6a9c0 September 4, 2024 03:23
@cambyzju
Copy link
Contributor Author

cambyzju commented Sep 4, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37828 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

------ Round 1 ----------------------------------
q1	17615	4379	4301	4301
q2	2021	177	173	173
q3	11875	924	1131	924
q4	10510	685	778	685
q5	7758	2813	2800	2800
q6	221	137	140	137
q7	958	605	592	592
q8	9337	2054	2055	2054
q9	7020	6499	6511	6499
q10	6991	2215	2183	2183
q11	434	242	237	237
q12	389	218	223	218
q13	17771	3072	3062	3062
q14	280	235	233	233
q15	521	485	491	485
q16	576	513	499	499
q17	966	669	649	649
q18	7337	6890	6805	6805
q19	1391	1027	991	991
q20	664	339	319	319
q21	3867	3191	2982	2982
q22	1114	1037	1000	1000
Total cold run time: 109616 ms
Total hot run time: 37828 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4370	4316	4267	4267
q2	366	276	267	267
q3	2876	2640	2732	2640
q4	1951	1656	1659	1656
q5	5589	5752	5744	5744
q6	226	137	146	137
q7	2243	1817	1848	1817
q8	3301	3466	3470	3466
q9	8883	8948	8917	8917
q10	3612	3301	3464	3301
q11	622	510	523	510
q12	834	643	708	643
q13	15019	3201	3284	3201
q14	316	301	283	283
q15	537	484	492	484
q16	640	578	583	578
q17	1841	1528	1489	1489
q18	8574	8347	8405	8347
q19	6724	1702	1506	1506
q20	2131	1914	1933	1914
q21	5900	5513	5570	5513
q22	1136	1058	1062	1058
Total cold run time: 77691 ms
Total hot run time: 57738 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.85% (9396/25500)
Line Coverage: 28.28% (77499/274087)
Region Coverage: 27.68% (40002/144524)
Branch Coverage: 24.32% (20359/83702)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e09f2ffe0cd770b4a8aa2b24aa745127f8283260_e09f2ffe0cd770b4a8aa2b24aa745127f8283260/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 192609 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

query1	1243	889	876	876
query2	6431	1889	1928	1889
query3	10681	4148	4195	4148
query4	60018	26431	22975	22975
query5	5376	495	506	495
query6	399	175	157	157
query7	5752	300	294	294
query8	297	199	193	193
query9	8994	2514	2493	2493
query10	480	274	287	274
query11	17909	14942	15413	14942
query12	149	105	99	99
query13	1593	383	375	375
query14	11180	7465	7404	7404
query15	244	175	189	175
query16	7457	530	504	504
query17	1139	578	569	569
query18	2021	291	294	291
query19	291	152	143	143
query20	132	113	110	110
query21	204	104	107	104
query22	4598	4427	4536	4427
query23	34363	33559	33402	33402
query24	5933	2887	2892	2887
query25	543	401	405	401
query26	697	158	160	158
query27	1773	280	275	275
query28	3865	2065	2057	2057
query29	695	430	428	428
query30	234	152	152	152
query31	903	775	782	775
query32	85	51	57	51
query33	420	299	306	299
query34	848	482	469	469
query35	851	703	715	703
query36	1051	965	940	940
query37	144	90	87	87
query38	3980	3841	3967	3841
query39	1448	1389	1391	1389
query40	206	121	119	119
query41	49	48	45	45
query42	123	97	95	95
query43	510	464	474	464
query44	1089	738	741	738
query45	203	166	167	166
query46	1084	744	763	744
query47	1896	1803	1819	1803
query48	378	302	304	302
query49	773	446	502	446
query50	809	412	423	412
query51	7103	6847	6831	6831
query52	95	87	87	87
query53	259	178	179	178
query54	577	455	461	455
query55	76	76	75	75
query56	290	260	255	255
query57	1196	1045	1064	1045
query58	228	220	228	220
query59	3004	2783	2737	2737
query60	295	289	295	289
query61	128	104	96	96
query62	769	646	652	646
query63	215	185	190	185
query64	2789	683	692	683
query65	3182	3130	3119	3119
query66	695	336	344	336
query67	15375	15193	15258	15193
query68	3176	581	584	581
query69	402	286	291	286
query70	1149	1104	1044	1044
query71	373	277	281	277
query72	6321	4094	4007	4007
query73	752	320	328	320
query74	9518	8769	8798	8769
query75	3375	2664	2725	2664
query76	1532	970	953	953
query77	581	325	326	325
query78	9617	9836	9121	9121
query79	1072	543	519	519
query80	726	537	508	508
query81	535	235	239	235
query82	287	145	150	145
query83	173	151	148	148
query84	255	70	76	70
query85	798	281	281	281
query86	305	266	290	266
query87	4377	4259	4324	4259
query88	3400	2331	2331	2331
query89	395	291	280	280
query90	1694	195	188	188
query91	124	101	101	101
query92	65	50	51	50
query93	1079	538	535	535
query94	562	298	297	297
query95	391	254	251	251
query96	585	261	271	261
query97	3206	3058	3075	3058
query98	217	199	195	195
query99	1530	1270	1269	1269
Total cold run time: 306389 ms
Total hot run time: 192609 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.9 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

query1	0.04	0.05	0.04
query2	0.07	0.04	0.04
query3	0.23	0.04	0.04
query4	1.68	0.07	0.07
query5	0.51	0.50	0.51
query6	1.14	0.74	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.55	0.49	0.48
query10	0.54	0.53	0.54
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.58	0.58
query14	2.11	2.03	2.05
query15	0.89	0.82	0.83
query16	0.38	0.38	0.38
query17	1.02	1.05	1.05
query18	0.20	0.20	0.19
query19	1.92	1.80	1.77
query20	0.01	0.00	0.01
query21	15.40	0.67	0.65
query22	3.72	7.21	1.78
query23	18.28	1.43	1.27
query24	2.18	0.22	0.21
query25	0.15	0.08	0.08
query26	0.27	0.18	0.19
query27	0.08	0.09	0.08
query28	13.21	1.00	1.00
query29	12.62	3.30	3.27
query30	0.25	0.05	0.06
query31	2.87	0.40	0.39
query32	3.26	0.47	0.49
query33	3.03	2.99	3.07
query34	17.42	4.42	4.42
query35	4.48	4.47	4.44
query36	0.66	0.49	0.49
query37	0.18	0.16	0.16
query38	0.15	0.14	0.15
query39	0.04	0.04	0.04
query40	0.15	0.13	0.13
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.86 s
Total hot run time: 31.9 s

@cambyzju
Copy link
Contributor Author

cambyzju commented Sep 4, 2024

run Code Formatter

@cambyzju
Copy link
Contributor Author

cambyzju commented Sep 4, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38255 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

------ Round 1 ----------------------------------
q1	17827	4402	4302	4302
q2	2021	181	180	180
q3	11780	963	1139	963
q4	10523	725	757	725
q5	7759	2871	2862	2862
q6	231	142	142	142
q7	960	628	601	601
q8	9324	2091	2103	2091
q9	7235	6550	6545	6545
q10	6992	2231	2193	2193
q11	463	244	244	244
q12	394	228	231	228
q13	17751	3075	3055	3055
q14	285	237	237	237
q15	551	486	496	486
q16	580	516	507	507
q17	987	748	804	748
q18	7338	6883	6797	6797
q19	1398	1104	976	976
q20	676	341	346	341
q21	3955	3217	3013	3013
q22	1114	1039	1019	1019
Total cold run time: 110144 ms
Total hot run time: 38255 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4382	4337	4348	4337
q2	373	274	263	263
q3	2914	2730	2690	2690
q4	1954	1676	1682	1676
q5	5656	5742	5799	5742
q6	232	136	143	136
q7	2248	1854	1852	1852
q8	3307	3430	3534	3430
q9	8840	8810	8829	8810
q10	3622	3419	3311	3311
q11	622	516	509	509
q12	864	664	712	664
q13	15861	3287	3351	3287
q14	329	300	290	290
q15	553	491	509	491
q16	653	581	608	581
q17	1848	1549	1528	1528
q18	8118	7923	7893	7893
q19	1734	1610	1542	1542
q20	2109	1952	1908	1908
q21	5795	5429	5359	5359
q22	1137	1034	1081	1034
Total cold run time: 73151 ms
Total hot run time: 57333 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.84% (9395/25499)
Line Coverage: 28.28% (77503/274032)
Region Coverage: 27.67% (39987/144499)
Branch Coverage: 24.32% (20348/83684)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e09f2ffe0cd770b4a8aa2b24aa745127f8283260_e09f2ffe0cd770b4a8aa2b24aa745127f8283260/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 192642 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

query1	1251	867	862	862
query2	6440	1963	1955	1955
query3	10661	4109	3945	3945
query4	59100	24294	23216	23216
query5	5321	534	513	513
query6	406	178	163	163
query7	5773	295	301	295
query8	286	203	204	203
query9	8876	2556	2544	2544
query10	472	290	271	271
query11	18389	15144	15189	15144
query12	150	101	106	101
query13	1588	400	379	379
query14	11225	7701	7130	7130
query15	223	177	186	177
query16	7313	456	529	456
query17	1095	593	571	571
query18	1835	301	294	294
query19	298	145	149	145
query20	118	109	119	109
query21	212	110	104	104
query22	4591	4451	4711	4451
query23	34350	32923	33663	32923
query24	6005	2889	2937	2889
query25	541	406	423	406
query26	684	167	156	156
query27	1765	291	284	284
query28	3836	2087	2073	2073
query29	658	428	424	424
query30	250	158	155	155
query31	955	773	784	773
query32	78	51	60	51
query33	432	292	296	292
query34	854	490	494	490
query35	857	724	698	698
query36	1054	931	929	929
query37	146	93	92	92
query38	3982	3988	3854	3854
query39	1436	1394	1382	1382
query40	213	126	123	123
query41	51	48	47	47
query42	118	97	96	96
query43	517	491	481	481
query44	1104	754	757	754
query45	196	167	164	164
query46	1098	776	775	775
query47	1851	1784	1847	1784
query48	396	315	311	311
query49	788	450	463	450
query50	840	417	428	417
query51	6945	6961	6906	6906
query52	105	87	91	87
query53	259	185	185	185
query54	583	464	519	464
query55	77	74	76	74
query56	281	266	250	250
query57	1202	1101	1015	1015
query58	207	243	242	242
query59	3079	2777	2814	2777
query60	298	278	269	269
query61	117	101	98	98
query62	742	661	695	661
query63	225	187	192	187
query64	2358	687	710	687
query65	3212	3107	3156	3107
query66	694	364	353	353
query67	15401	15305	15082	15082
query68	3367	590	587	587
query69	405	276	280	276
query70	1191	1103	1071	1071
query71	369	287	287	287
query72	6317	4000	4050	4000
query73	772	327	332	327
query74	9149	8891	8869	8869
query75	3318	2683	2750	2683
query76	1355	1001	1034	1001
query77	548	324	318	318
query78	9820	9089	9471	9089
query79	1116	556	536	536
query80	815	513	519	513
query81	551	236	234	234
query82	411	156	153	153
query83	173	147	153	147
query84	259	78	80	78
query85	809	291	314	291
query86	306	304	296	296
query87	4392	4265	4316	4265
query88	3043	2398	2387	2387
query89	394	285	301	285
query90	1739	191	187	187
query91	129	100	100	100
query92	62	49	51	49
query93	1088	543	545	543
query94	621	275	299	275
query95	342	258	257	257
query96	594	266	269	266
query97	3248	3085	3066	3066
query98	217	214	210	210
query99	1760	1284	1251	1251
Total cold run time: 305143 ms
Total hot run time: 192642 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.1 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.08	0.08
query5	0.50	0.48	0.50
query6	1.12	0.73	0.74
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.48	0.49
query10	0.55	0.52	0.53
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.59	0.58
query14	2.11	2.06	2.07
query15	0.90	0.82	0.82
query16	0.37	0.38	0.37
query17	0.99	0.97	1.03
query18	0.21	0.20	0.20
query19	1.92	1.79	1.72
query20	0.01	0.01	0.01
query21	15.39	0.66	0.66
query22	4.44	6.83	2.03
query23	18.27	1.42	1.41
query24	2.13	0.23	0.22
query25	0.15	0.08	0.08
query26	0.27	0.17	0.17
query27	0.07	0.07	0.08
query28	13.23	1.01	1.01
query29	12.66	3.28	3.25
query30	0.24	0.06	0.05
query31	2.89	0.41	0.40
query32	3.24	0.50	0.48
query33	2.99	2.99	3.04
query34	16.74	4.35	4.40
query35	4.46	4.42	4.43
query36	0.67	0.48	0.46
query37	0.18	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.05	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 110.83 s
Total hot run time: 32.1 s

@cambyzju
Copy link
Contributor Author

cambyzju commented Sep 5, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.84% (9393/25500)
Line Coverage: 28.26% (77449/274055)
Region Coverage: 27.66% (39972/144521)
Branch Coverage: 24.30% (20340/83702)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e09f2ffe0cd770b4a8aa2b24aa745127f8283260_e09f2ffe0cd770b4a8aa2b24aa745127f8283260/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 37794 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

------ Round 1 ----------------------------------
q1	17625	4409	4269	4269
q2	2019	187	181	181
q3	11706	962	1221	962
q4	10517	734	768	734
q5	7757	2799	2754	2754
q6	224	139	140	139
q7	959	599	598	598
q8	9324	2062	2043	2043
q9	7049	6514	6544	6514
q10	6976	2248	2255	2248
q11	443	231	236	231
q12	392	224	226	224
q13	18949	3059	3125	3059
q14	269	240	225	225
q15	520	496	499	496
q16	576	515	490	490
q17	973	645	693	645
q18	7443	6870	6750	6750
q19	1403	1078	1012	1012
q20	667	334	316	316
q21	3894	2965	2921	2921
q22	1107	983	1053	983
Total cold run time: 110792 ms
Total hot run time: 37794 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4304	4261	4250	4250
q2	368	272	277	272
q3	2858	2669	2639	2639
q4	1962	1603	1653	1603
q5	5606	5652	5669	5652
q6	228	147	148	147
q7	2256	1859	1811	1811
q8	3314	3394	3440	3394
q9	8842	8868	8869	8868
q10	3543	3359	3357	3357
q11	616	511	539	511
q12	820	653	688	653
q13	14524	3312	3217	3217
q14	332	293	289	289
q15	523	480	514	480
q16	615	620	576	576
q17	1823	1523	1539	1523
q18	8178	7840	7807	7807
q19	1727	1572	1469	1469
q20	2168	1914	1912	1912
q21	5826	5411	5422	5411
q22	1137	1076	1036	1036
Total cold run time: 71570 ms
Total hot run time: 56877 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192231 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

query1	1251	861	876	861
query2	6304	1946	1836	1836
query3	10622	3979	3878	3878
query4	59678	26129	23201	23201
query5	5437	478	499	478
query6	392	169	152	152
query7	5895	288	286	286
query8	284	197	202	197
query9	8916	2514	2479	2479
query10	478	264	276	264
query11	18299	14973	15320	14973
query12	159	107	103	103
query13	1555	398	394	394
query14	10241	6967	7231	6967
query15	241	178	182	178
query16	7662	502	471	471
query17	1131	571	572	571
query18	2112	289	306	289
query19	302	146	146	146
query20	124	106	105	105
query21	203	112	113	112
query22	4787	4623	4702	4623
query23	34279	33383	33403	33383
query24	5924	2817	2888	2817
query25	542	408	397	397
query26	687	159	155	155
query27	1775	276	281	276
query28	3974	2080	2068	2068
query29	724	425	422	422
query30	238	157	155	155
query31	923	783	797	783
query32	84	55	54	54
query33	440	289	288	288
query34	879	471	477	471
query35	833	717	712	712
query36	1045	919	933	919
query37	149	88	90	88
query38	3946	3863	3888	3863
query39	1485	1393	1376	1376
query40	198	117	116	116
query41	48	48	50	48
query42	119	95	95	95
query43	506	479	471	471
query44	1077	741	738	738
query45	208	174	170	170
query46	1097	740	748	740
query47	1938	1809	1836	1809
query48	395	302	301	301
query49	772	444	437	437
query50	819	414	415	414
query51	7067	6901	6914	6901
query52	100	89	87	87
query53	249	179	186	179
query54	586	476	465	465
query55	75	75	76	75
query56	277	266	327	266
query57	1208	1045	1073	1045
query58	219	220	224	220
query59	2967	2739	2743	2739
query60	291	269	256	256
query61	99	98	104	98
query62	729	660	621	621
query63	214	175	206	175
query64	2826	655	674	655
query65	3213	3114	3163	3114
query66	679	340	333	333
query67	15463	15233	15473	15233
query68	3452	574	564	564
query69	402	294	280	280
query70	1221	1117	1113	1113
query71	336	280	276	276
query72	6367	3999	3942	3942
query73	758	332	337	332
query74	9306	8848	8914	8848
query75	3354	2697	2721	2697
query76	1408	973	1030	973
query77	530	322	324	322
query78	9719	9042	9018	9018
query79	1048	542	525	525
query80	722	503	504	503
query81	539	235	231	231
query82	248	150	145	145
query83	169	151	146	146
query84	260	74	76	74
query85	734	284	271	271
query86	320	300	307	300
query87	4407	4275	4289	4275
query88	3498	2459	2341	2341
query89	386	277	283	277
query90	2115	183	183	183
query91	122	95	101	95
query92	59	49	49	49
query93	1073	523	531	523
query94	765	289	296	289
query95	341	246	244	244
query96	585	269	267	267
query97	3213	3087	3099	3087
query98	216	219	203	203
query99	1590	1295	1246	1246
Total cold run time: 306702 ms
Total hot run time: 192231 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.08 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e09f2ffe0cd770b4a8aa2b24aa745127f8283260, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.03
query3	0.22	0.05	0.05
query4	1.67	0.08	0.08
query5	0.53	0.51	0.49
query6	1.13	0.74	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.54	0.54	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	2.10	2.13	2.07
query15	0.89	0.85	0.81
query16	0.36	0.38	0.38
query17	1.04	1.04	1.04
query18	0.21	0.19	0.20
query19	1.94	1.87	1.85
query20	0.01	0.01	0.01
query21	15.40	0.65	0.65
query22	5.02	6.47	1.91
query23	18.29	1.49	1.27
query24	2.11	0.22	0.21
query25	0.16	0.08	0.09
query26	0.27	0.18	0.18
query27	0.07	0.08	0.08
query28	13.24	1.01	1.00
query29	12.66	3.32	3.30
query30	0.24	0.06	0.05
query31	2.91	0.39	0.40
query32	3.23	0.47	0.48
query33	3.03	2.98	2.98
query34	16.80	4.36	4.40
query35	4.47	4.50	4.44
query36	0.65	0.48	0.47
query37	0.20	0.15	0.16
query38	0.14	0.14	0.15
query39	0.05	0.04	0.04
query40	0.16	0.12	0.12
query41	0.10	0.05	0.06
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 111.59 s
Total hot run time: 32.08 s

lide-reed
lide-reed approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

PR approved by at least one committer and no changes requested.

liutang123
liutang123 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@liutang123 liutang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cambyzju cambyzju merged commit 2baed5c into apache:master Sep 5, 2024
23 of 28 checks passed
@cambyzju
Copy link
Contributor Author

cambyzju commented Sep 5, 2024

first pick pr(#40285) to branch 2.1, then pick this pr(#40004) to branch 2.1

cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Sep 11, 2024
@cambyzju
[feature](aes_encrypt) support GCM mode for aes_encrypt and aes_decry…
9bb4c91 
…pt (apache#40004)
@cambyzju cambyzju mentioned this pull request Sep 11, 2024
Merged
yiguolei pushed a commit that referenced this pull request Sep 11, 2024
@cambyzju
[feature](aes_encrypt) support GCM mode for aes_encrypt and aes_decry…
361a59d 
…pt (#40004) (#40672)

pick #40004 to branch-2.1
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@cambyzju @dataroaring
[feature](aes_encrypt) support GCM mode for aes_encrypt and aes_decry…
278ee2f 
…pt (#40004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow left review comments

@lide-reed lide-reed lide-reed approved these changes

@liutang123 liutang123 liutang123 approved these changes

@xinyiZzz xinyiZzz xinyiZzz left review comments

@zhangstar333 zhangstar333 zhangstar333 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cambyzju @doris-robot @lide-reed @xinyiZzz @liutang123 @zhangstar333 @morrySnow @yiguolei