[Bug] test suite test_table_options may cause NPE in FE #39457 #39509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Vallishp
force-pushed
the
table_option_bug
branch
from
f9d8b67
to
89540d1
Compare
|
run buildall |
TPC-H: Total hot run time: 38241 ms |
TPC-DS: Total hot run time: 196595 ms |
ClickBench: Total hot run time: 31.73 s |
yiguolei
previously approved these changes
Aug 17, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
previously approved these changes
Aug 17, 2024
Vallishp
force-pushed
the
table_option_bug
branch
from
89540d1
to
a7ed271
Compare
|
run buildall |
TPC-H: Total hot run time: 37572 ms |
TPC-H: Total hot run time: 37808 ms |
TPC-DS: Total hot run time: 196935 ms |
ClickBench: Total hot run time: 32.09 s |
yiguolei
approved these changes
Aug 18, 2024
|
run beut |
yiguolei
force-pushed
the
table_option_bug
branch
from
52ccf44
to
8da9d21
Compare
|
run buildall |
TPC-H: Total hot run time: 37962 ms |
TPC-DS: Total hot run time: 196078 ms |
ClickBench: Total hot run time: 30.61 s |
wangbo
pushed a commit
to wangbo/incubator-doris
that referenced
this pull request
Aug 28, 2024
yiguolei
pushed a commit
that referenced
this pull request
Aug 28, 2024
…39457 (#39509) (#40018) ## Proposed changes pick #39509 Co-authored-by: Vallish Pai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #39457
If database is delete then FE should check and return OK with empty set to BE, so that BE can continue the scan other database id
Unit testing:
stubbed BE to add a invalid database id in the begin of the dbresult.dbids and reproduced this issue.
mysql> select * from information_schema.table_options;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]TStatus: Cannot invoke "org.apache.doris.catalog.DatabaseIf.getTables()" because "database" is null
mysql> select * from information_schema.table_properties;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]TStatus: Cannot invoke "org.apache.doris.catalog.DatabaseIf.getTables()" because "database" is null
mysql>
After fix in FE both table query success with invalid dbid from BE.
*************************** 776. row ***************************
TABLE_CATALOG: internal
TABLE_SCHEMA: regression_test_tpch_unique_sql_zstd_bucket1_p0
TABLE_NAME: partsupp
TABLE_MODEL: UNI
TABLE_MODEL_KEY: PS_PARTKEY,PS_SUPPKEY
DISTRIBUTE_KEY: PS_PARTKEY
DISTRIBUTE_TYPE: HASH
BUCKETS_NUM: 1
PARTITION_NUM: 1
776 rows in set (0.11 sec)
mysql>
Both table can query even if in the begining there is a invalid dbid in BE list.