[Chore](runtime-filter) avoid dcheck fail when rf merge failed #39172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
zhiqiang-hhhh
approved these changes
Aug 9, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 10, 2024
## Proposed changes avoid dcheck fail when rf merge failed there is a difference in the logic of calculating bf size between 2.1 and 3.0, so the merge will fail this pr is to prevent core dump caused by dcheck failure during rolling upgrade.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
…e#39172) ## Proposed changes avoid dcheck fail when rf merge failed there is a difference in the logic of calculating bf size between 2.1 and 3.0, so the merge will fail this pr is to prevent core dump caused by dcheck failure during rolling upgrade.
BiteTheDDDDt
added a commit
that referenced
this pull request
Sep 5, 2024
## Proposed changes avoid dcheck fail when rf merge failed there is a difference in the logic of calculating bf size between 2.1 and 3.0, so the merge will fail this pr is to prevent core dump caused by dcheck failure during rolling upgrade.
hello-stephen
pushed a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
avoid dcheck fail when rf merge failed
there is a difference in the logic of calculating bf size between 2.1 and 3.0, so the merge will fail
this pr is to prevent core dump caused by dcheck failure during rolling upgrade.