Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](move-memtable) add more fault injection cases for writer v2 #39169

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Aug 9, 2024

Proposed changes

Add more fault injection cases for writer v2 to improve coverage.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Contributor Author

kaijchen commented Aug 9, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39762 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2d79f6624b0888b3286602f2c84841643e3ccb09, data reload: false

------ Round 1 ----------------------------------
q1	18080	4496	4403	4403
q2	2892	181	184	181
q3	11362	1167	1148	1148
q4	11217	726	749	726
q5	7600	2567	2525	2525
q6	232	142	147	142
q7	973	586	600	586
q8	9217	1902	1881	1881
q9	8714	6548	6560	6548
q10	7023	2204	2229	2204
q11	475	242	253	242
q12	390	226	219	219
q13	17797	3011	2985	2985
q14	275	245	240	240
q15	527	483	486	483
q16	501	383	379	379
q17	966	739	715	715
q18	8040	7516	7337	7337
q19	4681	1007	1014	1007
q20	696	343	348	343
q21	5516	4479	4551	4479
q22	1124	989	1004	989
Total cold run time: 118298 ms
Total hot run time: 39762 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4415	4290	4337	4290
q2	373	260	256	256
q3	2827	2601	2627	2601
q4	1911	1601	1658	1601
q5	5247	5297	5281	5281
q6	220	131	130	130
q7	2020	1641	1688	1641
q8	3159	3330	3319	3319
q9	8401	8344	8411	8344
q10	3389	3142	3146	3142
q11	594	479	520	479
q12	789	643	608	608
q13	17196	2985	2992	2985
q14	298	265	281	265
q15	527	485	471	471
q16	471	411	408	408
q17	1792	1510	1450	1450
q18	7754	7363	7274	7274
q19	1663	1488	1467	1467
q20	1967	1796	1771	1771
q21	5262	4976	5124	4976
q22	1079	1011	1012	1011
Total cold run time: 71354 ms
Total hot run time: 53770 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 200293 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2d79f6624b0888b3286602f2c84841643e3ccb09, data reload: false

query1	905	367	358	358
query2	6455	1872	1816	1816
query3	6647	213	213	213
query4	34279	23182	23467	23182
query5	4176	504	515	504
query6	287	177	174	174
query7	4593	302	306	302
query8	250	198	193	193
query9	8505	2471	2453	2453
query10	526	470	460	460
query11	15763	14825	15044	14825
query12	146	94	91	91
query13	1631	389	356	356
query14	10343	7721	6926	6926
query15	278	225	212	212
query16	7725	480	477	477
query17	1714	560	556	556
query18	1963	298	292	292
query19	191	146	149	146
query20	114	110	107	107
query21	203	109	106	106
query22	4399	4148	4031	4031
query23	33942	33109	33356	33109
query24	11960	2610	2575	2575
query25	673	402	413	402
query26	1817	156	156	156
query27	2929	289	287	287
query28	7450	2039	2029	2029
query29	1183	429	435	429
query30	305	148	153	148
query31	975	766	762	762
query32	99	57	57	57
query33	744	304	290	290
query34	896	458	474	458
query35	933	846	797	797
query36	1076	923	921	921
query37	282	82	82	82
query38	4264	4057	4114	4057
query39	1424	1507	1390	1390
query40	277	124	119	119
query41	49	45	45	45
query42	117	98	101	98
query43	499	473	453	453
query44	1248	750	735	735
query45	236	200	206	200
query46	1108	760	723	723
query47	1877	1770	1762	1762
query48	375	305	303	303
query49	1209	445	437	437
query50	811	411	407	407
query51	6810	6788	6755	6755
query52	99	93	95	93
query53	260	187	184	184
query54	941	467	457	457
query55	80	76	81	76
query56	364	244	239	239
query57	1190	1086	1080	1080
query58	242	223	228	223
query59	2919	2763	2636	2636
query60	287	283	280	280
query61	95	125	94	94
query62	824	645	660	645
query63	209	181	177	177
query64	10452	2244	1757	1757
query65	3216	3125	3123	3123
query66	1371	342	338	338
query67	15375	14761	14977	14761
query68	4609	552	552	552
query69	417	410	379	379
query70	1167	1089	1109	1089
query71	426	278	272	272
query72	18471	17135	16653	16653
query73	760	331	334	331
query74	9120	8684	8833	8684
query75	3654	2642	2634	2634
query76	2963	1020	980	980
query77	487	318	316	316
query78	9775	8901	8960	8901
query79	4957	511	532	511
query80	1664	489	494	489
query81	596	229	225	225
query82	1522	140	135	135
query83	318	150	148	148
query84	277	79	127	79
query85	1515	285	268	268
query86	435	290	294	290
query87	4663	4540	4685	4540
query88	4787	2511	2494	2494
query89	437	281	291	281
query90	2019	193	194	193
query91	120	97	93	93
query92	61	49	48	48
query93	5419	536	535	535
query94	1028	277	250	250
query95	357	257	259	257
query96	618	277	276	276
query97	3226	2997	3045	2997
query98	216	197	202	197
query99	1566	1299	1267	1267
Total cold run time: 322235 ms
Total hot run time: 200293 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2d79f6624b0888b3286602f2c84841643e3ccb09, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.67	0.07	0.08
query5	0.53	0.49	0.48
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.54	0.48	0.46
query10	0.55	0.54	0.54
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.60	0.58
query14	0.77	0.77	0.77
query15	0.88	0.80	0.82
query16	0.38	0.37	0.36
query17	1.03	1.02	1.03
query18	0.23	0.22	0.22
query19	1.79	1.78	1.70
query20	0.01	0.00	0.01
query21	15.39	0.75	0.66
query22	3.84	7.87	1.91
query23	18.30	1.47	1.33
query24	2.07	0.21	0.22
query25	0.16	0.09	0.07
query26	0.29	0.21	0.21
query27	0.45	0.22	0.23
query28	13.34	1.02	0.99
query29	12.64	3.35	3.30
query30	0.23	0.05	0.05
query31	2.88	0.39	0.40
query32	3.27	0.48	0.48
query33	2.86	2.95	2.88
query34	17.09	4.35	4.36
query35	4.48	4.41	4.43
query36	0.65	0.48	0.49
query37	0.18	0.16	0.16
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.15	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.06	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.48 s
Total hot run time: 30.7 s

@kaijchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39226 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 41c0c205cc3365830d4d3fdfaac42f06ba7ba71e, data reload: false

------ Round 1 ----------------------------------
q1	17623	4350	4257	4257
q2	2028	174	170	170
q3	10498	1120	1030	1030
q4	10141	722	767	722
q5	7504	2543	2477	2477
q6	223	141	142	141
q7	958	595	587	587
q8	9219	1898	2034	1898
q9	8604	6527	6529	6527
q10	7050	2223	2194	2194
q11	474	244	249	244
q12	442	224	222	222
q13	19027	3017	2986	2986
q14	279	234	237	234
q15	527	499	491	491
q16	502	400	394	394
q17	975	823	687	687
q18	8131	7539	7414	7414
q19	4096	1067	966	966
q20	737	332	320	320
q21	5288	4247	4313	4247
q22	1118	1018	1041	1018
Total cold run time: 115444 ms
Total hot run time: 39226 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4478	4245	4250	4245
q2	384	274	265	265
q3	2840	2552	2629	2552
q4	1977	1742	1710	1710
q5	5506	5500	5509	5500
q6	221	135	133	133
q7	2094	1762	1854	1762
q8	3375	3428	3466	3428
q9	8770	8805	8889	8805
q10	3466	3267	3304	3267
q11	582	503	504	503
q12	796	605	622	605
q13	17110	3191	3172	3172
q14	318	303	289	289
q15	553	487	500	487
q16	497	446	451	446
q17	1859	1530	1500	1500
q18	8120	7952	7850	7850
q19	5871	1626	1477	1477
q20	2182	1926	1855	1855
q21	5695	5546	5155	5155
q22	1153	1103	1043	1043
Total cold run time: 77847 ms
Total hot run time: 56049 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 201861 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 41c0c205cc3365830d4d3fdfaac42f06ba7ba71e, data reload: false

query1	908	370	362	362
query2	6442	2047	1919	1919
query3	6650	208	212	208
query4	29733	23212	23180	23180
query5	3587	481	493	481
query6	282	164	166	164
query7	4576	303	303	303
query8	251	204	196	196
query9	8730	2536	2503	2503
query10	534	491	445	445
query11	17766	15043	14944	14944
query12	133	99	99	99
query13	1642	383	371	371
query14	10347	7031	8169	7031
query15	261	216	215	215
query16	7419	493	490	490
query17	1751	572	554	554
query18	1408	289	292	289
query19	194	151	152	151
query20	114	111	107	107
query21	209	106	110	106
query22	4657	4592	4288	4288
query23	34549	34045	34208	34045
query24	10780	2709	2640	2640
query25	587	403	409	403
query26	710	155	159	155
query27	2212	296	297	296
query28	6060	2081	2064	2064
query29	747	437	428	428
query30	264	155	154	154
query31	985	755	811	755
query32	96	54	58	54
query33	664	275	272	272
query34	866	462	460	460
query35	949	844	819	819
query36	1105	928	920	920
query37	137	82	81	81
query38	4312	4204	4168	4168
query39	1464	1376	1364	1364
query40	197	111	117	111
query41	49	42	42	42
query42	121	94	95	94
query43	511	455	458	455
query44	1182	727	729	727
query45	233	208	206	206
query46	1102	721	735	721
query47	1834	1780	1741	1741
query48	372	297	297	297
query49	831	442	425	425
query50	804	418	412	412
query51	6903	6734	6712	6712
query52	106	90	91	90
query53	253	181	181	181
query54	866	449	437	437
query55	79	75	74	74
query56	265	240	252	240
query57	1190	1067	1047	1047
query58	232	219	229	219
query59	3125	2665	2695	2665
query60	283	270	265	265
query61	98	120	94	94
query62	815	649	664	649
query63	209	187	182	182
query64	9177	2289	1757	1757
query65	3205	3157	3180	3157
query66	730	331	355	331
query67	15596	14694	14801	14694
query68	5294	540	545	540
query69	433	385	384	384
query70	1170	1109	1146	1109
query71	535	277	278	277
query72	19683	16363	16457	16363
query73	779	327	327	327
query74	9043	8780	8788	8780
query75	4494	2678	2711	2678
query76	3899	1009	1038	1009
query77	696	316	324	316
query78	9733	9081	8930	8930
query79	7529	505	529	505
query80	2167	488	497	488
query81	607	238	226	226
query82	791	136	139	136
query83	265	141	190	141
query84	265	76	77	76
query85	1326	280	274	274
query86	379	294	297	294
query87	4744	4512	4549	4512
query88	4936	2500	2505	2500
query89	424	287	285	285
query90	2022	201	201	201
query91	125	100	96	96
query92	59	52	49	49
query93	5831	543	532	532
query94	900	295	289	289
query95	353	266	268	266
query96	617	275	275	275
query97	3269	3036	3070	3036
query98	261	206	194	194
query99	1532	1264	1264	1264
Total cold run time: 318610 ms
Total hot run time: 201861 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.82 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 41c0c205cc3365830d4d3fdfaac42f06ba7ba71e, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.48	0.50	0.48
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.55	0.48	0.49
query10	0.54	0.54	0.55
query11	0.16	0.12	0.12
query12	0.15	0.12	0.13
query13	0.61	0.62	0.58
query14	0.77	0.77	0.80
query15	0.85	0.82	0.81
query16	0.36	0.36	0.37
query17	1.04	1.05	1.00
query18	0.22	0.22	0.22
query19	1.79	1.71	1.82
query20	0.01	0.02	0.01
query21	15.39	0.75	0.65
query22	4.09	7.62	2.13
query23	18.28	1.42	1.24
query24	2.09	0.22	0.22
query25	0.16	0.08	0.08
query26	0.30	0.21	0.21
query27	0.46	0.23	0.22
query28	13.32	1.02	1.01
query29	12.58	3.31	3.28
query30	0.23	0.05	0.04
query31	2.89	0.39	0.39
query32	3.28	0.47	0.47
query33	2.92	2.92	2.98
query34	17.04	4.35	4.36
query35	4.46	4.40	4.40
query36	0.66	0.45	0.47
query37	0.20	0.16	0.16
query38	0.15	0.16	0.15
query39	0.05	0.04	0.04
query40	0.15	0.12	0.12
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.05	0.03	0.04
Total cold run time: 109.67 s
Total hot run time: 30.82 s

@kaijchen kaijchen marked this pull request as ready for review August 13, 2024 19:19
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 14, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@liaoxin01 liaoxin01 added dev/2.1.x and removed approved Indicates a PR has been approved by one committer. reviewed labels Aug 14, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a5a5b32 into apache:master Aug 23, 2024
29 of 31 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 23, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring pushed a commit that referenced this pull request Aug 26, 2024
…39169)

## Proposed changes

Add more fault injection cases for writer v2 to improve coverage.
@kaijchen kaijchen deleted the DORIS-13829-1 branch September 19, 2024 07:40
kaijchen added a commit to kaijchen/doris that referenced this pull request Sep 19, 2024
…pache#39169)

## Proposed changes

Add more fault injection cases for writer v2 to improve coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged doing reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants