-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](S3) Use allocator for s3 buffer's allocation #38519
base: branch-2.0
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
run buildall |
1 similar comment
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 50407 ms
|
TPC-DS: Total hot run time: 205193 ms
|
ClickBench: Total hot run time: 31.33 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
TPC-H: Total hot run time: 49921 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 202617 ms
|
ClickBench: Total hot run time: 31.34 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
TPC-H: Total hot run time: 50056 ms
|
TPC-DS: Total hot run time: 203707 ms
|
ClickBench: Total hot run time: 30.09 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
TeamCity be ut coverage result: |
no lambda check init
7374818
to
397818a
Compare
run buildall |
TPC-H: Total hot run time: 50080 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 203833 ms
|
ClickBench: Total hot run time: 31.44 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
Proposed changes
Remove the static buffer pool for S3 upload. Use the dynamic allocator to control the memory usage for S3 upload which is more adaptive and easy to use. Remove all the useless config plus.