Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](Nereids) forbid some commands fallback when parse failed #35197

Merged
merged 1 commit into from
May 23, 2024
Merged

[chore](Nereids) forbid some commands fallback when parse failed #35197

merged 1 commit into from
May 23, 2024

Conversation

morrySnow
Copy link
Contributor

  1. CreateTableLikeCommand
  2. CreateViewCommand
  3. AlterViewCommand

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40167 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f430c6b8376464b1b85ce8b8d1bec5c0d3b49e58, data reload: false

------ Round 1 ----------------------------------
q1	18243	4451	4527	4451
q2	2457	190	194	190
q3	11758	1194	1205	1194
q4	10323	778	827	778
q5	7534	2740	2724	2724
q6	218	133	138	133
q7	961	602	595	595
q8	9296	2110	2079	2079
q9	8963	6503	6480	6480
q10	8951	3728	3724	3724
q11	459	239	234	234
q12	496	225	218	218
q13	17778	2982	3007	2982
q14	255	216	224	216
q15	508	464	475	464
q16	524	396	379	379
q17	967	690	710	690
q18	8103	7494	7465	7465
q19	4231	1563	1414	1414
q20	653	306	305	305
q21	4940	3184	3908	3184
q22	344	277	268	268
Total cold run time: 117962 ms
Total hot run time: 40167 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4307	4227	4158	4158
q2	379	271	275	271
q3	3014	2754	2717	2717
q4	1881	1617	1593	1593
q5	5250	5284	5268	5268
q6	210	122	124	122
q7	2123	1747	1767	1747
q8	3200	3304	3321	3304
q9	8312	8339	8341	8339
q10	3885	3662	3679	3662
q11	577	495	492	492
q12	745	580	597	580
q13	16835	2994	2997	2994
q14	285	259	263	259
q15	509	475	463	463
q16	475	426	420	420
q17	1770	1464	1495	1464
q18	7564	7643	7382	7382
q19	1666	1566	1547	1547
q20	1981	1783	1781	1781
q21	4861	4599	4803	4599
q22	556	491	495	491
Total cold run time: 70385 ms
Total hot run time: 53653 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171971 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f430c6b8376464b1b85ce8b8d1bec5c0d3b49e58, data reload: false

query1	925	390	368	368
query2	6464	2270	2257	2257
query3	6656	204	204	204
query4	19642	17488	17286	17286
query5	4202	416	418	416
query6	255	150	148	148
query7	4584	289	291	289
query8	243	192	187	187
query9	8527	2391	2360	2360
query10	456	287	286	286
query11	10705	10091	10039	10039
query12	139	90	87	87
query13	1671	362	366	362
query14	10026	7375	7741	7375
query15	269	165	174	165
query16	8135	278	260	260
query17	1827	537	540	537
query18	2032	287	274	274
query19	211	172	155	155
query20	101	88	90	88
query21	204	131	127	127
query22	4229	3911	4002	3911
query23	33719	33155	32974	32974
query24	12108	2792	2880	2792
query25	631	344	346	344
query26	1732	153	153	153
query27	2986	323	330	323
query28	7525	2060	2045	2045
query29	997	596	610	596
query30	309	172	173	172
query31	996	761	769	761
query32	96	51	57	51
query33	765	268	257	257
query34	1036	456	456	456
query35	756	611	582	582
query36	1060	939	909	909
query37	272	72	70	70
query38	2905	2760	2756	2756
query39	864	810	797	797
query40	272	121	122	121
query41	46	43	42	42
query42	100	92	95	92
query43	573	533	515	515
query44	1198	736	738	736
query45	179	169	162	162
query46	1077	720	771	720
query47	1851	1791	1753	1753
query48	359	290	305	290
query49	1192	375	379	375
query50	759	381	374	374
query51	6882	6793	6745	6745
query52	99	90	87	87
query53	363	280	283	280
query54	943	439	424	424
query55	80	72	75	72
query56	283	245	246	245
query57	1128	1018	1028	1018
query58	234	207	221	207
query59	3290	3155	3280	3155
query60	268	250	243	243
query61	91	87	88	87
query62	659	445	468	445
query63	313	284	283	283
query64	9813	2186	1709	1709
query65	3193	3079	3101	3079
query66	1353	337	316	316
query67	15414	14886	14723	14723
query68	4776	546	542	542
query69	478	267	271	267
query70	1173	1100	1043	1043
query71	448	259	280	259
query72	7530	5237	5697	5237
query73	723	323	318	318
query74	6193	5652	5589	5589
query75	3648	2606	2619	2606
query76	3613	975	1028	975
query77	633	265	264	264
query78	10445	9811	9996	9811
query79	1974	515	517	515
query80	865	433	427	427
query81	535	239	243	239
query82	724	96	93	93
query83	292	175	164	164
query84	235	85	84	84
query85	1576	301	268	268
query86	472	302	312	302
query87	3385	3087	3128	3087
query88	4087	2320	2321	2320
query89	464	388	386	386
query90	1972	187	187	187
query91	123	95	102	95
query92	62	48	48	48
query93	2206	524	495	495
query94	1212	183	187	183
query95	410	310	307	307
query96	582	261	261	261
query97	3166	3011	3029	3011
query98	253	223	217	217
query99	1158	854	863	854
Total cold run time: 277685 ms
Total hot run time: 171971 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.19 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f430c6b8376464b1b85ce8b8d1bec5c0d3b49e58, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.03	0.04
query3	0.24	0.05	0.06
query4	1.66	0.08	0.09
query5	0.48	0.49	0.51
query6	1.12	0.74	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.47
query10	0.54	0.54	0.52
query11	0.16	0.11	0.11
query12	0.14	0.13	0.12
query13	0.60	0.64	0.60
query14	0.81	0.76	0.78
query15	0.83	0.82	0.82
query16	0.36	0.37	0.36
query17	0.94	0.94	0.96
query18	0.21	0.22	0.26
query19	1.75	1.67	1.72
query20	0.02	0.01	0.02
query21	15.54	0.66	0.66
query22	3.96	7.13	1.62
query23	18.22	1.36	1.28
query24	1.52	0.36	0.20
query25	0.15	0.09	0.08
query26	0.25	0.17	0.17
query27	0.07	0.08	0.07
query28	13.34	1.03	1.01
query29	13.19	3.31	3.30
query30	0.24	0.08	0.05
query31	2.91	0.40	0.39
query32	3.22	0.47	0.47
query33	2.89	2.89	2.87
query34	17.33	4.42	4.42
query35	4.53	4.58	4.53
query36	0.65	0.45	0.51
query37	0.17	0.15	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.04
query40	0.17	0.13	0.15
query41	0.08	0.04	0.05
query42	0.05	0.05	0.04
query43	0.04	0.03	0.04
Total cold run time: 109.32 s
Total hot run time: 30.19 s

@morrySnow
Copy link
Contributor Author

run feut

@morrySnow
Copy link
Contributor Author

run p0

@morrySnow
[chore](Nereids) forbid some commands fallback when parse failed
8369ed2 
1. CreateTableLikeCommand
2. CreateViewCommand
3. AlterViewCommand
@morrySnow morrySnow force-pushed the forbid_fallback_new_command branch from f430c6b to 8369ed2 Compare May 22, 2024 12:29
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 170955 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8369ed2fdaa464ee32e24941a48aafca90503537, data reload: false

query1	917	380	363	363
query2	6741	2409	2279	2279
query3	6652	209	203	203
query4	19252	17829	17785	17785
query5	3876	442	427	427
query6	254	169	161	161
query7	4548	305	297	297
query8	232	204	188	188
query9	8605	2457	2425	2425
query10	438	292	260	260
query11	11352	10981	10563	10563
query12	118	85	88	85
query13	1706	366	366	366
query14	9539	7809	7604	7604
query15	272	173	174	173
query16	8258	280	271	271
query17	2073	564	544	544
query18	2122	295	292	292
query19	205	174	167	167
query20	98	87	84	84
query21	201	135	131	131
query22	4220	3919	3781	3781
query23	33670	32956	33196	32956
query24	10999	2822	2770	2770
query25	637	389	372	372
query26	1354	159	163	159
query27	2931	336	315	315
query28	7441	2021	2024	2021
query29	911	689	620	620
query30	262	170	170	170
query31	990	771	745	745
query32	92	52	53	52
query33	761	262	265	262
query34	984	476	486	476
query35	724	612	587	587
query36	1079	952	915	915
query37	146	76	68	68
query38	2858	2759	2768	2759
query39	827	808	799	799
query40	197	125	124	124
query41	45	42	41	41
query42	103	98	94	94
query43	551	541	556	541
query44	1278	727	727	727
query45	177	163	163	163
query46	1083	724	721	721
query47	1835	1753	1763	1753
query48	370	296	296	296
query49	894	373	377	373
query50	751	382	384	382
query51	6864	6857	6862	6857
query52	107	87	91	87
query53	368	291	282	282
query54	875	423	416	416
query55	73	72	74	72
query56	265	241	248	241
query57	1131	1041	1069	1041
query58	230	205	221	205
query59	3350	3033	3234	3033
query60	282	261	252	252
query61	88	86	83	83
query62	656	475	490	475
query63	312	293	296	293
query64	8794	2239	1705	1705
query65	3157	3107	3116	3107
query66	1365	323	319	319
query67	15047	14828	14880	14828
query68	4987	537	537	537
query69	508	265	272	265
query70	1199	1098	1114	1098
query71	467	277	270	270
query72	8554	5275	2746	2746
query73	763	319	319	319
query74	6056	5636	5567	5567
query75	3770	2610	2641	2610
query76	3622	1056	932	932
query77	646	278	269	269
query78	10361	9744	9663	9663
query79	2716	525	532	525
query80	1826	440	462	440
query81	538	245	239	239
query82	1354	99	96	96
query83	328	169	166	166
query84	267	89	83	83
query85	1543	271	276	271
query86	480	303	302	302
query87	3316	3222	3156	3156
query88	4007	2343	2320	2320
query89	487	392	394	392
query90	1969	190	185	185
query91	126	95	93	93
query92	66	53	48	48
query93	2450	504	511	504
query94	1186	185	185	185
query95	397	312	310	310
query96	599	266	269	266
query97	3179	3067	3020	3020
query98	235	221	218	218
query99	1289	854	860	854
Total cold run time: 277884 ms
Total hot run time: 170955 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8369ed2fdaa464ee32e24941a48aafca90503537, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.09	0.09
query5	0.49	0.50	0.52
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.53	0.48	0.48
query10	0.55	0.55	0.53
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.60	0.59	0.60
query14	0.75	0.77	0.77
query15	0.82	0.80	0.80
query16	0.36	0.38	0.36
query17	0.96	0.99	0.99
query18	0.24	0.24	0.26
query19	1.89	1.80	1.80
query20	0.02	0.01	0.02
query21	15.49	0.70	0.66
query22	4.04	7.80	1.63
query23	18.27	1.41	1.33
query24	1.92	0.23	0.20
query25	0.16	0.08	0.09
query26	0.26	0.16	0.17
query27	0.08	0.08	0.08
query28	13.27	1.01	1.00
query29	12.81	3.35	3.35
query30	0.24	0.06	0.05
query31	2.86	0.38	0.38
query32	3.31	0.46	0.47
query33	2.91	2.90	2.92
query34	17.32	4.40	4.46
query35	4.52	4.59	4.54
query36	0.68	0.48	0.46
query37	0.18	0.15	0.15
query38	0.15	0.16	0.14
query39	0.04	0.03	0.04
query40	0.16	0.14	0.15
query41	0.08	0.04	0.05
query42	0.05	0.04	0.05
query43	0.04	0.03	0.03
Total cold run time: 109.57 s
Total hot run time: 30.53 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 67a3ff7 into apache:master May 23, 2024
27 of 28 checks passed
@morrySnow morrySnow deleted the forbid_fallback_new_command branch May 23, 2024 02:41
dataroaring pushed a commit that referenced this pull request May 26, 2024
@morrySnow @dataroaring
[chore](Nereids) forbid some commands fallback when parse failed (#35197
a523b11 
)

1. CreateTableLikeCommand
2. CreateViewCommand
3. AlterViewCommand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.0-merged not-merge/2.1 reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @doris-robot @starocean999 @feiniaofeiafei @yiguolei @dataroaring