Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil #35154

Merged
merged 1 commit into from
May 22, 2024

Conversation

morrySnow
Copy link
Contributor

pick from master #35153

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49332 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ae677dea3f92dab65c3065709a459e6c9b5c9858, data reload: false

------ Round 1 ----------------------------------
q1	18279	4390	4275	4275
q2	2030	154	140	140
q3	10468	1905	1846	1846
q4	10325	1210	1306	1210
q5	8418	3898	3884	3884
q6	232	123	126	123
q7	2010	1576	1595	1576
q8	9523	2729	2695	2695
q9	14096	10196	10218	10196
q10	8632	3515	3490	3490
q11	419	242	255	242
q12	465	297	313	297
q13	18357	3972	4012	3972
q14	349	332	333	332
q15	527	455	461	455
q16	667	572	564	564
q17	1130	925	933	925
q18	7241	6788	6869	6788
q19	1703	1601	1544	1544
q20	535	320	299	299
q21	4374	4157	4093	4093
q22	492	386	403	386
Total cold run time: 120272 ms
Total hot run time: 49332 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4298	4273	4284	4273
q2	321	222	225	222
q3	4177	4146	4152	4146
q4	2746	2730	2739	2730
q5	7227	7126	7029	7029
q6	234	124	123	123
q7	3219	2860	2872	2860
q8	4314	4454	4468	4454
q9	16818	16743	16784	16743
q10	4347	4278	4236	4236
q11	779	686	695	686
q12	1017	856	845	845
q13	7288	3746	3725	3725
q14	455	423	434	423
q15	501	452	460	452
q16	740	691	672	672
q17	3768	3931	3955	3931
q18	8775	8754	8795	8754
q19	1710	1673	1625	1625
q20	2372	2135	2108	2108
q21	8406	8455	8497	8455
q22	1026	917	961	917
Total cold run time: 84538 ms
Total hot run time: 79409 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 203295 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ae677dea3f92dab65c3065709a459e6c9b5c9858, data reload: false

query1	932	383	378	378
query2	6521	2687	2690	2687
query3	6926	207	211	207
query4	20545	17970	17871	17871
query5	19732	6498	6519	6498
query6	280	220	232	220
query7	4160	304	316	304
query8	259	267	247	247
query9	3167	2695	2637	2637
query10	411	283	311	283
query11	11409	10676	10766	10676
query12	120	75	75	75
query13	5583	679	669	669
query14	17765	13543	13392	13392
query15	355	217	227	217
query16	6466	267	252	252
query17	1789	1439	872	872
query18	2321	407	405	405
query19	210	152	150	150
query20	75	76	81	76
query21	187	98	98	98
query22	5179	5011	5020	5011
query23	32491	31933	31854	31854
query24	6985	6587	6530	6530
query25	507	428	417	417
query26	527	160	161	160
query27	1878	299	301	299
query28	6151	2358	2312	2312
query29	2900	2724	2640	2640
query30	238	164	163	163
query31	907	749	729	729
query32	71	63	57	57
query33	399	251	233	233
query34	865	483	493	483
query35	1128	889	925	889
query36	1374	1108	1146	1108
query37	89	62	60	60
query38	3084	2898	2950	2898
query39	1362	1334	1321	1321
query40	202	92	94	92
query41	45	41	36	36
query42	83	86	92	86
query43	721	694	688	688
query44	1121	718	717	717
query45	245	234	231	231
query46	1247	974	965	965
query47	1872	1734	1828	1734
query48	1006	711	716	711
query49	618	366	362	362
query50	855	601	614	601
query51	4723	4603	4631	4603
query52	90	84	70	70
query53	452	314	317	314
query54	2637	2453	2476	2453
query55	89	88	83	83
query56	249	220	198	198
query57	1180	1176	1068	1068
query58	217	207	198	198
query59	4102	3976	3793	3793
query60	208	214	202	202
query61	92	85	84	84
query62	820	457	494	457
query63	478	332	341	332
query64	2284	1524	1446	1446
query65	3667	3578	3535	3535
query66	772	377	368	368
query67	17812	15375	15240	15240
query68	8217	647	647	647
query69	555	343	350	343
query70	1618	1274	1572	1274
query71	396	316	322	316
query72	6399	3504	3401	3401
query73	731	327	327	327
query74	6317	5849	5837	5837
query75	4470	3664	3759	3664
query76	4670	1166	1172	1166
query77	581	258	261	258
query78	12433	12635	12143	12143
query79	10314	647	654	647
query80	1039	399	387	387
query81	506	231	235	231
query82	1113	97	97	97
query83	180	134	143	134
query84	258	68	68	68
query85	795	299	297	297
query86	344	289	316	289
query87	3235	3031	3047	3031
query88	5150	2373	2377	2373
query89	413	320	302	302
query90	1843	219	199	199
query91	169	136	144	136
query92	63	53	55	53
query93	5627	574	578	574
query94	748	209	209	209
query95	1117	1064	1039	1039
query96	646	339	329	329
query97	6396	6407	6449	6407
query98	192	179	172	172
query99	2646	1018	900	900
Total cold run time: 312416 ms
Total hot run time: 203295 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ae677dea3f92dab65c3065709a459e6c9b5c9858, data reload: false

query1	0.02	0.02	0.03
query2	0.07	0.03	0.02
query3	0.24	0.06	0.05
query4	1.79	0.07	0.08
query5	0.53	0.53	0.52
query6	1.26	0.61	0.65
query7	0.01	0.01	0.00
query8	0.04	0.02	0.03
query9	0.52	0.49	0.48
query10	0.53	0.55	0.54
query11	0.13	0.09	0.08
query12	0.11	0.08	0.08
query13	0.61	0.61	0.62
query14	0.76	0.80	0.78
query15	0.79	0.75	0.76
query16	0.37	0.36	0.37
query17	1.03	0.99	1.03
query18	0.21	0.25	0.25
query19	1.94	1.85	1.84
query20	0.01	0.01	0.01
query21	15.46	0.56	0.53
query22	2.15	2.24	1.48
query23	16.95	1.07	1.00
query24	4.47	1.38	0.96
query25	0.33	0.08	0.05
query26	0.58	0.16	0.16
query27	0.04	0.03	0.04
query28	8.80	0.78	0.76
query29	12.68	2.36	2.21
query30	0.55	0.53	0.53
query31	2.80	0.38	0.38
query32	3.39	0.48	0.49
query33	3.06	3.08	3.05
query34	15.28	4.82	4.77
query35	4.85	4.81	4.81
query36	1.06	1.01	1.01
query37	0.06	0.05	0.04
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.15	0.14	0.14
query41	0.07	0.01	0.01
query42	0.02	0.01	0.02
query43	0.02	0.01	0.02
Total cold run time: 103.8 s
Total hot run time: 30.53 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit ae677dea3f92dab65c3065709a459e6c9b5c9858 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49750 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dd48e7210a556be37bb543e3fbf8918954c1533e, data reload: false

------ Round 1 ----------------------------------
q1	17771	4378	4326	4326
q2	2043	149	146	146
q3	10431	1877	1878	1877
q4	10331	1220	1319	1220
q5	8535	3896	3918	3896
q6	234	124	124	124
q7	2025	1591	1611	1591
q8	9306	2733	2711	2711
q9	11025	10611	10523	10523
q10	8647	3480	3486	3480
q11	425	246	250	246
q12	463	302	306	302
q13	18332	3945	4027	3945
q14	364	329	326	326
q15	501	462	461	461
q16	687	557	580	557
q17	1141	976	996	976
q18	7286	6806	6899	6806
q19	1683	1580	1508	1508
q20	515	311	289	289
q21	4448	4045	4067	4045
q22	503	397	395	395
Total cold run time: 116696 ms
Total hot run time: 49750 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4312	4253	4280	4253
q2	322	222	229	222
q3	4150	4111	4170	4111
q4	2749	2736	2732	2732
q5	7129	7126	7133	7126
q6	235	121	117	117
q7	3212	2822	2763	2763
q8	4324	4438	4528	4438
q9	17345	16898	17201	16898
q10	4187	4214	4257	4214
q11	748	696	674	674
q12	1032	851	846	846
q13	6728	3726	3722	3722
q14	444	422	439	422
q15	510	450	460	450
q16	728	683	681	681
q17	3793	3853	3841	3841
q18	8814	8677	8804	8677
q19	1708	1693	1658	1658
q20	2383	2168	2106	2106
q21	8401	8390	8444	8390
q22	998	929	968	929
Total cold run time: 84252 ms
Total hot run time: 79270 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 202154 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dd48e7210a556be37bb543e3fbf8918954c1533e, data reload: false

query1	946	385	379	379
query2	6537	2804	2520	2520
query3	6922	207	209	207
query4	19807	17949	17862	17862
query5	19731	6448	6498	6448
query6	296	220	225	220
query7	4165	299	308	299
query8	263	249	248	248
query9	3084	2663	2602	2602
query10	418	309	291	291
query11	11202	10756	10698	10698
query12	124	77	71	71
query13	5597	686	649	649
query14	17340	13186	13456	13186
query15	359	220	222	220
query16	6456	270	260	260
query17	1724	1477	873	873
query18	2289	404	407	404
query19	213	146	150	146
query20	79	79	81	79
query21	190	93	92	92
query22	5319	4996	5187	4996
query23	32436	31915	31946	31915
query24	7040	6484	6495	6484
query25	515	424	417	417
query26	526	156	165	156
query27	1895	306	295	295
query28	6174	2328	2294	2294
query29	2894	2673	2656	2656
query30	235	165	166	165
query31	901	724	748	724
query32	73	61	61	61
query33	399	250	256	250
query34	855	470	490	470
query35	1131	917	971	917
query36	1390	1402	1206	1206
query37	92	57	61	57
query38	3084	2933	2924	2924
query39	1356	1308	1327	1308
query40	201	94	86	86
query41	38	36	39	36
query42	90	81	84	81
query43	761	685	817	685
query44	1130	720	718	718
query45	246	236	225	225
query46	1227	956	968	956
query47	1945	1683	1787	1683
query48	1010	717	698	698
query49	609	365	371	365
query50	866	580	593	580
query51	4724	4643	4695	4643
query52	96	82	74	74
query53	439	314	318	314
query54	2665	2433	2470	2433
query55	100	75	81	75
query56	235	205	208	205
query57	1132	1050	1141	1050
query58	201	204	209	204
query59	4049	4018	3761	3761
query60	204	182	186	182
query61	91	86	85	85
query62	852	480	461	461
query63	468	345	339	339
query64	2371	1613	1406	1406
query65	3638	3539	3512	3512
query66	814	378	391	378
query67	15467	15404	16295	15404
query68	8917	658	658	658
query69	572	341	337	337
query70	1596	1654	1432	1432
query71	407	305	315	305
query72	6417	3459	3443	3443
query73	726	326	324	324
query74	6247	5877	5725	5725
query75	5249	3668	3667	3667
query76	5417	1146	1225	1146
query77	921	253	249	249
query78	12710	11809	11489	11489
query79	10265	673	668	668
query80	1678	381	389	381
query81	498	238	228	228
query82	1653	100	94	94
query83	163	131	133	131
query84	264	68	67	67
query85	852	301	297	297
query86	320	288	320	288
query87	3210	2998	2995	2995
query88	4978	2340	2341	2340
query89	482	287	307	287
query90	1972	206	206	206
query91	169	131	133	131
query92	59	52	52	52
query93	7157	576	569	569
query94	701	207	203	203
query95	1081	1046	1020	1020
query96	646	323	333	323
query97	6619	6416	6382	6382
query98	188	167	165	165
query99	3130	864	879	864
Total cold run time: 314990 ms
Total hot run time: 202154 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dd48e7210a556be37bb543e3fbf8918954c1533e, data reload: false

query1	0.02	0.02	0.03
query2	0.08	0.03	0.02
query3	0.25	0.04	0.04
query4	1.80	0.05	0.07
query5	0.53	0.52	0.52
query6	1.22	0.61	0.59
query7	0.02	0.01	0.01
query8	0.04	0.02	0.03
query9	0.53	0.49	0.49
query10	0.55	0.54	0.53
query11	0.12	0.09	0.08
query12	0.11	0.08	0.08
query13	0.62	0.61	0.61
query14	0.77	0.79	0.78
query15	0.79	0.75	0.76
query16	0.37	0.38	0.38
query17	1.01	0.99	1.00
query18	0.22	0.25	0.24
query19	1.93	1.89	1.84
query20	0.01	0.00	0.01
query21	15.50	0.55	0.54
query22	2.57	2.54	1.24
query23	16.68	1.10	0.81
query24	7.41	0.76	1.31
query25	0.40	0.12	0.04
query26	0.73	0.16	0.15
query27	0.04	0.03	0.04
query28	5.77	0.74	0.72
query29	12.65	2.34	2.35
query30	0.61	0.54	0.54
query31	2.80	0.38	0.38
query32	3.39	0.50	0.49
query33	3.07	3.07	3.07
query34	15.25	4.82	4.79
query35	4.84	4.84	4.84
query36	1.07	1.01	1.02
query37	0.05	0.05	0.04
query38	0.04	0.02	0.02
query39	0.02	0.01	0.01
query40	0.16	0.14	0.14
query41	0.06	0.01	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 104.14 s
Total hot run time: 30.04 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit dd48e7210a556be37bb543e3fbf8918954c1533e with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49800 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0f6d804b031781f71d22099f4473c11df40a009c, data reload: false

------ Round 1 ----------------------------------
q1	17680	4423	4333	4333
q2	2043	163	146	146
q3	10472	1869	1884	1869
q4	10359	1243	1322	1243
q5	8495	3900	3960	3900
q6	228	129	124	124
q7	2030	1629	1611	1611
q8	9560	2787	2721	2721
q9	14228	10485	10444	10444
q10	8637	3529	3511	3511
q11	420	249	260	249
q12	476	299	311	299
q13	18364	3972	4018	3972
q14	352	324	320	320
q15	497	463	461	461
q16	656	564	568	564
q17	1144	938	897	897
q18	7176	6878	6807	6807
q19	1681	1611	1565	1565
q20	552	293	319	293
q21	4449	4119	4089	4089
q22	486	382	396	382
Total cold run time: 119985 ms
Total hot run time: 49800 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4386	4330	4330	4330
q2	324	231	228	228
q3	4208	4166	4179	4166
q4	2746	2737	2768	2737
q5	7210	7077	7110	7077
q6	240	121	121	121
q7	3259	2839	2854	2839
q8	4374	4472	4471	4471
q9	17528	16988	16990	16988
q10	4223	4235	4266	4235
q11	747	728	699	699
q12	1011	822	837	822
q13	7280	3731	3757	3731
q14	455	434	432	432
q15	511	457	451	451
q16	738	686	681	681
q17	3880	3878	3832	3832
q18	8821	8843	8818	8818
q19	1745	1670	1701	1670
q20	2414	2151	2144	2144
q21	8485	8546	8576	8546
q22	1062	902	948	902
Total cold run time: 85647 ms
Total hot run time: 79920 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 204152 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0f6d804b031781f71d22099f4473c11df40a009c, data reload: false

query1	964	388	379	379
query2	6543	2738	2633	2633
query3	6920	214	208	208
query4	20192	17994	18112	17994
query5	19719	6517	6562	6517
query6	314	228	228	228
query7	4408	301	315	301
query8	250	245	220	220
query9	3150	2686	2598	2598
query10	434	316	322	316
query11	11452	10746	10736	10736
query12	122	79	72	72
query13	5593	678	686	678
query14	18571	13357	13217	13217
query15	362	224	228	224
query16	6441	270	257	257
query17	1662	1465	871	871
query18	2332	404	402	402
query19	209	150	150	150
query20	80	78	77	77
query21	193	97	100	97
query22	5126	4998	4973	4973
query23	32530	32144	32014	32014
query24	6765	6544	6533	6533
query25	520	439	450	439
query26	526	162	157	157
query27	1857	294	295	294
query28	6190	2384	2324	2324
query29	2927	2851	2673	2673
query30	247	169	170	169
query31	914	732	722	722
query32	70	64	63	63
query33	407	252	242	242
query34	845	493	479	479
query35	1146	929	915	915
query36	1467	1261	1169	1169
query37	91	61	64	61
query38	3063	2955	2943	2943
query39	1390	1339	1325	1325
query40	207	94	92	92
query41	39	42	36	36
query42	87	79	82	79
query43	768	657	683	657
query44	1143	709	711	709
query45	237	233	227	227
query46	1224	959	980	959
query47	2051	1734	1695	1695
query48	1019	728	699	699
query49	611	365	369	365
query50	871	634	597	597
query51	4770	4670	4680	4670
query52	100	80	79	79
query53	442	319	314	314
query54	2676	2476	2469	2469
query55	90	80	84	80
query56	239	207	219	207
query57	1250	1151	1094	1094
query58	222	185	215	185
query59	4075	4055	3570	3570
query60	215	203	195	195
query61	90	87	86	86
query62	813	454	465	454
query63	507	340	337	337
query64	2549	1505	1445	1445
query65	3631	3567	3585	3567
query66	811	393	381	381
query67	17967	15505	15411	15411
query68	8707	645	654	645
query69	567	335	351	335
query70	1568	1368	1323	1323
query71	416	336	302	302
query72	6496	3451	3423	3423
query73	740	327	328	327
query74	6365	5869	5822	5822
query75	5224	3660	3583	3583
query76	5080	1120	1111	1111
query77	855	259	261	259
query78	12821	12820	13441	12820
query79	11999	649	652	649
query80	777	396	388	388
query81	497	234	236	234
query82	407	108	98	98
query83	181	133	129	129
query84	263	70	70	70
query85	750	307	302	302
query86	329	286	290	286
query87	3266	3004	3024	3004
query88	5397	2397	2424	2397
query89	429	324	285	285
query90	2585	200	200	200
query91	169	135	135	135
query92	58	55	52	52
query93	5030	572	552	552
query94	1255	217	209	209
query95	1099	1049	1027	1027
query96	674	346	339	339
query97	6486	6483	6421	6421
query98	191	174	186	174
query99	2955	922	999	922
Total cold run time: 318332 ms
Total hot run time: 204152 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.42 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0f6d804b031781f71d22099f4473c11df40a009c, data reload: false

query1	0.02	0.02	0.03
query2	0.07	0.02	0.02
query3	0.25	0.04	0.04
query4	1.80	0.06	0.05
query5	0.53	0.52	0.52
query6	1.23	0.61	0.60
query7	0.01	0.01	0.01
query8	0.04	0.02	0.02
query9	0.52	0.48	0.48
query10	0.56	0.54	0.53
query11	0.12	0.08	0.09
query12	0.11	0.10	0.09
query13	0.61	0.62	0.62
query14	0.79	0.77	0.78
query15	0.78	0.78	0.76
query16	0.36	0.37	0.38
query17	1.04	1.01	1.01
query18	0.21	0.27	0.25
query19	1.92	1.84	1.89
query20	0.02	0.01	0.01
query21	15.47	0.56	0.55
query22	2.33	3.03	1.65
query23	16.82	1.02	0.83
query24	5.48	0.82	1.37
query25	0.37	0.10	0.06
query26	0.61	0.18	0.15
query27	0.04	0.05	0.05
query28	7.44	0.73	0.78
query29	12.62	2.12	2.20
query30	0.56	0.54	0.54
query31	2.82	0.39	0.38
query32	3.38	0.49	0.49
query33	3.09	3.02	3.08
query34	15.27	4.82	4.81
query35	4.86	4.86	4.88
query36	1.07	1.02	1.03
query37	0.06	0.04	0.04
query38	0.03	0.02	0.02
query39	0.02	0.02	0.02
query40	0.16	0.13	0.14
query41	0.07	0.02	0.01
query42	0.03	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 103.61 s
Total hot run time: 30.42 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 0f6d804b031781f71d22099f4473c11df40a009c with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.1 seconds inserted 10000000 Rows, about 452K ops/s

@morrySnow
Copy link
Contributor Author

run external

@morrySnow morrySnow merged commit e495dd3 into apache:branch-2.0 May 22, 2024
23 of 24 checks passed
@morrySnow morrySnow deleted the 2.0_35153 branch May 27, 2024 09:08
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
…che#35153) (apache#35154)

pick from master apache#35153

1.  round floor was incorrectly implemented as round
2. round ceiling not really round because use double type when divide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants