Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression-test](load) add something like $.tag.[a.b] key's json case #35134

Merged
merged 3 commits into from
May 31, 2024
Merged

[regression-test](load) add something like $.tag.[a.b] key's json case #35134

merged 3 commits into from
May 31, 2024

Conversation

felixwluo
Copy link
Contributor

Proposed changes

1、json

{
        "tags": {
                "a.b": "test",
                "k2": "k2_value"
        }
}

add a regression test to parse a key like a.b

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@felixwluo
Copy link
Contributor Author

run buildall

cambyzju
cambyzju previously approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 22, 2024
@felixwluo
Copy link
Contributor Author

run p0

@cambyzju
Copy link
Contributor

run buildall

dataroaring
dataroaring approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 28, 2024
@cambyzju
Copy link
Contributor

run buildall

@cambyzju cambyzju merged commit cc1fef1 into apache:master May 31, 2024
25 of 26 checks passed
dataroaring pushed a commit that referenced this pull request May 31, 2024
@felixwluo @dataroaring
[regression-test](load) add something like $.tag.[a.b] key's json case (
2843f88 
#35134)
yiguolei pushed a commit that referenced this pull request May 31, 2024
@felixwluo @Doris-Extras
[regression-test](load) add something like $.tag.[a.b] key's json case (
48d4601 
#35134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cambyzju cambyzju cambyzju approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixwluo @doris-robot @cambyzju @dataroaring