-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[optimize](desc) display the correct data type of aggStateType #34968
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 41955 ms
|
TPC-DS: Total hot run time: 180846 ms
|
ClickBench: Total hot run time: 30.26 s
|
run external |
could u replace screenshot by code block? screeshot is hard to put into git message and not firendly for search engine |
OK, I modified my comment. |
If a table column is AGG_STATE type, we can't get the clear defined data type if we use `desc tbl` statement. create table a_table( k1 int null, k2 agg_state<max_by(int not null,int)> generic, k3 agg_state<group_concat(string)> generic ) aggregate key (k1) distributed BY hash(k1) buckets 3 properties("replication_num" = "1"); before optimize: mysql> desc a_table; +-------+------------------------------------------------+------+-------+---------+---------+ | Field | Type | Null | Key | Default | Extra | +-------+------------------------------------------------+------+-------+---------+---------+ | k1 | INT | Yes | true | NULL | | | k2 | org.apache.doris.catalog.AggStateType@239f771c | No | false | NULL | GENERIC | | k3 | org.apache.doris.catalog.AggStateType@2e535f50 | No | false | NULL | GENERIC | +-------+------------------------------------------------+------+-------+---------+---------+ 3 rows in set (0.00 sec) after optimize: mysql> desc a_table; +-------+------------------------------------+------+-------+---------+---------+ | Field | Type | Null | Key | Default | Extra | +-------+------------------------------------+------+-------+---------+---------+ | k1 | INT | Yes | true | NULL | | | k2 | AGG_STATE<max_by(INT, INT NULL)> | No | false | NULL | GENERIC | | k3 | AGG_STATE<group_concat(TEXT NULL)> | No | false | NULL | GENERIC | +-------+------------------------------------+------+-------+---------+---------+ Co-authored-by: duanxujian <[email protected]>
If a table column is AGG_STATE type, we can't get the clear defined data type if we use `desc tbl` statement. create table a_table( k1 int null, k2 agg_state<max_by(int not null,int)> generic, k3 agg_state<group_concat(string)> generic ) aggregate key (k1) distributed BY hash(k1) buckets 3 properties("replication_num" = "1"); before optimize: mysql> desc a_table; +-------+------------------------------------------------+------+-------+---------+---------+ | Field | Type | Null | Key | Default | Extra | +-------+------------------------------------------------+------+-------+---------+---------+ | k1 | INT | Yes | true | NULL | | | k2 | org.apache.doris.catalog.AggStateType@239f771c | No | false | NULL | GENERIC | | k3 | org.apache.doris.catalog.AggStateType@2e535f50 | No | false | NULL | GENERIC | +-------+------------------------------------------------+------+-------+---------+---------+ 3 rows in set (0.00 sec) after optimize: mysql> desc a_table; +-------+------------------------------------+------+-------+---------+---------+ | Field | Type | Null | Key | Default | Extra | +-------+------------------------------------+------+-------+---------+---------+ | k1 | INT | Yes | true | NULL | | | k2 | AGG_STATE<max_by(INT, INT NULL)> | No | false | NULL | GENERIC | | k3 | AGG_STATE<group_concat(TEXT NULL)> | No | false | NULL | GENERIC | +-------+------------------------------------+------+-------+---------+---------+ Co-authored-by: duanxujian <[email protected]>
If a table column is AGG_STATE type, we can't get the clear defined data type if we use
desc tbl
statement.before optimize:
after optimize: