[feature](Nereids): Add DAG to store function dependencies #33882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
keanji-x
changed the title
|
run buildall |
|
run buildall |
morrySnow
approved these changes
Apr 23, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
jackwener
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces a Directed Acyclic Graph (DAG) to store and manage function dependencies within the project. The key changes include:
Define a FuncDepsDAG class to represent each node in the graph, storing the function name and its dependencies.
Create a DAG class to manage the overall graph, with methods to add nodes, add edges (dependencies), and perform graph traversals.n dependencies for each plan:
Implement a method to traverse the DAG and compute the dependencies for each function in a given plan.
Ensure that the computed dependencies are properly stored and associated with the corresponding functions.
Add unit tests:
Create test cases to verify the correctness of the DAG implementation.
Test scenarios for adding nodes, adding edges, and computing function dependencies.
Ensure proper handling of cyclic dependencies and other edge cases.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...