[branch-2.1](auto-partition) pick auto partition and some more prs #33523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -544,16 +505,80 @@ Status VOlapTablePartitionParam::_create_partition_key(const TExprNode& t_expr, | |||
| part_key->second = column->size() - 1; | |||
| return Status::OK(); | |||
| } | |||
| // NOLINTEND(readability-function-size) | |||
|
|
|||
| Status VOlapTablePartitionParam::_create_partition_keys(const std::vector<TExprNode>& t_exprs, | |||
There was a problem hiding this comment.
warning: method '_create_partition_keys' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status VOlapTablePartitionParam::_create_partition_keys(const std::vector<TExprNode>& t_exprs, | |
| static Status VOlapTablePartitionParam::_create_partition_keys(const std::vector<TExprNode>& t_exprs, |
| @@ -21,11 +21,10 @@ | |||
| #pragma once | |||
|
|
|||
| #include <glog/logging.h> | |||
There was a problem hiding this comment.
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
#include <glog/logging.h>
^| @@ -18,23 +18,21 @@ | |||
| #pragma once | |||
|
|
|||
| // IWYU pragma: no_include <bits/chrono.h> | |||
| #include <fmt/format.h> | |||
There was a problem hiding this comment.
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
#include <fmt/format.h>
^
apache#32737) (apache#33412)" This reverts commit e574b35.
for auto partition, support nullable partition column.
for auto list partition, support create real null partition for null values.
for auto range partition, null value will raise a error now. but maybe we can improve this in the future
…e#32737) fix legacy planner grammer fix nereids planner parsing fix cases forbid auto range partition with null column fix CreateTableStmt with auto partition and some partition items. 1 and 2 are about apache#31585 doc pr: apache/doris-website#488
Fix threadpool hang on grace exit
… auto partition (apache#33439) support all intervals for date_trunc in auto partition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
picked:
and:
remove some cloud-relative code in above prs
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...