Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](jdbc catalog) Change Druid Pool dependency to version 1.2.11 #31703

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Mar 3, 2024

Proposed changes

Issue Number: close #xxx

In PR #30588, we upgraded the Druid Pool dependency to version 1.2.20 to address potential connection pool state anomalies when KeepAlive is set to true. However, since version 1.2.12, Druid Pool introduced a default 10-second socketTime timeout, which can cause the jdbc catalog to easily timeout during large queries. Therefore, this PR downgrades the Druid Pool dependency back to 1.2.11, which has resolved most of the KeepAlive issues without including the default socketTime timeout setting.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@zy-kkk zy-kkk added dev/2.0.x usercase Important user case type label labels Mar 3, 2024
@zy-kkk
Copy link
Member Author

zy-kkk commented Mar 3, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

PR approved by anyone and no changes requested.

Copy link
Collaborator

@LemonLiTree LemonLiTree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zy-kkk zy-kkk merged commit 1ef6a1b into apache:master Mar 4, 2024
26 of 31 checks passed
@zy-kkk zy-kkk deleted the druid_pool_version branch March 4, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.6-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants