-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](jdbc catalog) Change Druid Pool dependency to version 1.2.11 #31703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. |
run buildall |
morningman
approved these changes
Mar 4, 2024
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Mar 4, 2024
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
LemonLiTree
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Mar 4, 2024
zy-kkk
added a commit
that referenced
this pull request
Mar 4, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.0.6-merged
reviewed
usercase
Important user case type label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
In PR #30588, we upgraded the Druid Pool dependency to version 1.2.20 to address potential connection pool state anomalies when KeepAlive is set to true. However, since version 1.2.12, Druid Pool introduced a default 10-second socketTime timeout, which can cause the jdbc catalog to easily timeout during large queries. Therefore, this PR downgrades the Druid Pool dependency back to 1.2.11, which has resolved most of the KeepAlive issues without including the default socketTime timeout setting.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...