-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](catalog) cache the converted properties #30668
Conversation
Thank you for your contribution to Apache Doris. |
run buildall |
TPC-H: Total hot run time: 36599 ms
|
TPC-DS: Total hot run time: 175700 ms
|
ClickBench: Total hot run time: 30.77 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
TPC-H: Total hot run time: 36977 ms
|
TPC-DS: Total hot run time: 173261 ms
|
ClickBench: Total hot run time: 30.57 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
ccf3fa1
to
a6c3b79
Compare
run buildall |
TPC-H: Total hot run time: 37589 ms
|
TPC-DS: Total hot run time: 174449 ms
|
ClickBench: Total hot run time: 30.53 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
a6c3b79
to
f2cda8d
Compare
run buildall |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
convert properties may be a heavy operation, so we cache the result.
convert properties may be a heavy operation, so we cache the result.
convert properties may be a heavy operation, so we cache the result.
Proposed changes
convert properties may be a heavy operation, so we cache the result.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...