-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pipelinex](profile) improve memory counter of pipelineX #30538
Conversation
8f27b24
to
805519b
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 36868 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172244 ms
|
ClickBench: Total hot run time: 31.07 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run pipelinex_p0 |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
805519b
to
c102a6c
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 36672 ms
|
TPC-DS: Total hot run time: 172729 ms
|
ClickBench: Total hot run time: 30.44 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
c102a6c
to
57bc766
Compare
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37007 ms
|
TPC-DS: Total hot run time: 173086 ms
|
ClickBench: Total hot run time: 30.46 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
Proposed changes
Issue Number: close #xxx
Improve memory counters for operators, e.g.:
scanner merged:
scanner:
hash join sink merged:
hash join sink:
sort sink merged:
sort sink:
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...