-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](routine-load) update partition offset cache timely to avoid negative lag #30455
Conversation
6a3dc2b
to
e3dc434
Compare
run build |
e3dc434
to
5587604
Compare
run buildall |
TPC-H: Total hot run time: 37886 ms
|
TPC-DS: Total hot run time: 172510 ms
|
ClickBench: Total hot run time: 30.45 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
5587604
to
06cbb96
Compare
run buildall |
TPC-H: Total hot run time: 36671 ms
|
TPC-DS: Total hot run time: 171870 ms
|
ClickBench: Total hot run time: 30.8 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
TPC-H: Total hot run time: 37057 ms
|
TPC-DS: Total hot run time: 173166 ms
|
ClickBench: Total hot run time: 30.52 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
Proposed changes
Lag is negative when we use routine load, it is need check all partitions, for some partitions offset may be out of time.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...