Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain #28935 #28936

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

zhiqiang-hhhh
Copy link
Contributor

pick #28935

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Dec 24, 2023
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.74% (7990/21170)
Line Coverage: 29.45% (64915/220413)
Region Coverage: 28.92% (33390/115465)
Branch Coverage: 24.79% (17126/69094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1c3ea81f83e1111a4d8aa2270640506e01d5149a_1c3ea81f83e1111a4d8aa2270640506e01d5149a/report/index.html

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.74% (7990/21170)
Line Coverage: 29.45% (64913/220429)
Region Coverage: 28.91% (33386/115467)
Branch Coverage: 24.79% (17128/69104)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2f0f7eafaa84ca3ebe421ea40ca314d775bb7b97_2f0f7eafaa84ca3ebe421ea40ca314d775bb7b97/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.06 seconds
stream load tsv: 565 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17168117780 Bytes

@yiguolei yiguolei merged commit a433d85 into apache:branch-2.0 Dec 25, 2023
21 of 24 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the pick-28905 branch December 27, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Issues or PRs related to the query planner kind/test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants