Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.0](partial update) report error directly if missing rowsets during doing alignment when flushing memtable due to compaction #28679

Merged

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Dec 19, 2023

Proposed changes

related pr: #28468, #28676
report error directly if we find that situation in #28468 happens

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 19, 2023

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.86% (8003/21136)
Line Coverage: 29.52% (64969/220053)
Region Coverage: 29.02% (33452/115274)
Branch Coverage: 24.89% (17172/68980)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3181b9183fec3a7efdd18067c3378cef0eee45e5_3181b9183fec3a7efdd18067c3378cef0eee45e5/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.64 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17167434650 Bytes

@bobhan1 bobhan1 force-pushed the branch-2.0-report-error-partial-update branch from 3181b91 to 8822a4e Compare December 20, 2023 02:29
@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 20, 2023

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.83% (7995/21136)
Line Coverage: 29.50% (64917/220053)
Region Coverage: 28.98% (33409/115274)
Branch Coverage: 24.85% (17141/68980)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8822a4ee7b0cbeb663a9719f9f4356ba09588000_8822a4ee7b0cbeb663a9719f9f4356ba09588000/report/index.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 20, 2023

run clickbench

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.54 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162619947 Bytes

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 20, 2023
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants