Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cache) add sql cache conf cache_result_max_data_size #22645

Merged
merged 3 commits into from
Aug 9, 2023
Merged

[fix](cache) add sql cache conf cache_result_max_data_size #22645

merged 3 commits into from
Aug 9, 2023

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Aug 6, 2023

Proposed changes

Only the maximum number of rows in sql cache cache_result_max_row_count is not enough. If a row of data is too large, FE may OOM.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Aug 6, 2023

run buildall

1 similar comment
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Aug 6, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.55 seconds
stream load tsv: 546 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162152226 Bytes

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.52 seconds
stream load tsv: 510 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162526931 Bytes

yiguolei
yiguolei previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

PR approved by anyone and no changes requested.

morningman
morningman reviewed Aug 8, 2023
View reviewed changes
fe/fe-common/src/main/java/org/apache/doris/common/Config.java Outdated
/**
* Set the maximum data size that can be cached
*/
@ConfField(mutable = true, masterOnly = false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description field of @ConfField

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

fe/fe-core/src/main/java/org/apache/doris/qe/cache/Cache.java Outdated
@@ -88,6 +88,10 @@ protected boolean checkRowLimit() {
LOG.info("can not be cached. rowbatch size {} is more than {}", rowBatchBuilder.getRowSize(),
Config.cache_result_max_row_count);
return false;
} else if (rowBatchBuilder.getDataSize() > Config.cache_result_max_data_size) {
LOG.info("can not be cached. rowbatch data size {} is more than {}", rowBatchBuilder.getDataSize(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LOG.info("can not be cached. rowbatch data size {} is more than {}", rowBatchBuilder.getDataSize(),
LOG.debug("can not be cached. rowbatch data size {} is more than {}", rowBatchBuilder.getDataSize(),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xinyiZzz xinyiZzz force-pushed the 20230806_fix_sql_cache_size branch from 013b434 to 9b0f0a4 Compare August 8, 2023 17:52
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Aug 8, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 8, 2023
@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.42 seconds
stream load tsv: 511 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162325098 Bytes

yiguolei
yiguolei approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

PR approved by at least one committer and no changes requested.

morningman
morningman approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xinyiZzz xinyiZzz merged commit 77d3d4e into apache:master Aug 9, 2023
17 of 18 checks passed
xiaokang pushed a commit that referenced this pull request Aug 11, 2023
@xinyiZzz @xiaokang
[fix](cache) add sql cache conf cache_result_max_data_size (#22645)
01c5056 
Only the maximum number of rows in sql cache cache_result_max_row_count is not enough. If a row of data is too large, FE may OOM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged merge_conflict reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xinyiZzz @hello-stephen @morningman @yiguolei @xiaokang