-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](multi-catalog) Fix read error in mixed partition locations. #21399
Conversation
run buildall |
de2e81a
to
ca1bb80
Compare
run buildall |
ca1bb80
to
c6eec9b
Compare
run buildall |
TeamCity pipeline, clickbench performance test result: |
TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Issue Number: close #20948
Fix read error in mixed partition locations(for example, some partitions locations are on s3, other are on hdfs) by
getLocationType
of file split level instead of the table level.Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...