Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore](metrics) remove trace metrics code using runtime profile instand #21394

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

ZhangYu0123
Copy link
Contributor

Proposed changes

  1. remove trace metrics code and use runtime profile instand

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Jun 30, 2023
@ZhangYu0123
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ZhangYu0123 ZhangYu0123 changed the title [Chore](metrics) remove trace metrics code [Chore](metrics) remove trace metrics code using runtime profile instand Jun 30, 2023
@ZhangYu0123
Copy link
Contributor Author

run p1

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei added the dev/2.0.0 2.0.0 release label Jul 1, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor

yiguolei commented Jul 1, 2023

Great job, thanks for your contribution

@yiguolei yiguolei merged commit 1fe04b7 into apache:master Jul 1, 2023
16 of 18 checks passed
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 3, 2023
xiaokang pushed a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.0-merged kind/docs Categorizes issue or PR as related to documentation. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants