Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](regression test) drop table before run window test #21365

Closed

Conversation

yujun777
Copy link
Collaborator

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@yujun777
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

yiguolei commented Jul 1, 2023

run buildall

@yiguolei yiguolei added the dev/2.0.0 2.0.0 release label Jul 1, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

PR approved by anyone and no changes requested.

@yujun777 yujun777 force-pushed the fix-window-test-no-drop-table branch from 99d6cab to e651dca Compare July 3, 2023 11:33
@yujun777
Copy link
Collaborator Author

yujun777 commented Jul 3, 2023

run buildall

1 similar comment
@yujun777
Copy link
Collaborator Author

yujun777 commented Jul 7, 2023

run buildall

@yujun777 yujun777 force-pushed the fix-window-test-no-drop-table branch from cfbc564 to 7634715 Compare July 10, 2023 03:33
@yujun777
Copy link
Collaborator Author

run buildall

1 similar comment
@yujun777
Copy link
Collaborator Author

run buildall

@yujun777
Copy link
Collaborator Author

user_analysis 是一个dup表的, 新旧两个优化器都往该表写同样的数据
测试时不能drop该表

@yujun777 yujun777 closed this Jul 11, 2023
@xiaokang xiaokang removed the dev/2.0.0 2.0.0 release label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants