Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](multi-catalog) Fallback to refresh catalog when hms events are missing #21333

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

dutyu
Copy link
Contributor

@dutyu dutyu commented Jun 29, 2023

Fix #20227, the implementation has some problems and can not catch event-missing-exception.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@dutyu dutyu marked this pull request as ready for review June 29, 2023 08:58
@dutyu
Copy link
Contributor Author

dutyu commented Jun 29, 2023

run buildall

1 similar comment
@dutyu
Copy link
Contributor Author

dutyu commented Jun 29, 2023

run buildall

Copy link
Contributor

@zddr zddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman added the dev/2.0.0 2.0.0 release label Jul 3, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

PR approved by at least one committer and no changes requested.

王翔宇 added 3 commits July 3, 2023 19:24
…missing.

Fix apache#20227, the implementation has some problem and can not catch event-missing-exception.
…missing.

Fix apache#20227, the implementation has some problem and can not catch event-missing-exception.
…missing.

Fix apache#20227, the implementation has some problem and can not catch event-missing-exception.
@morningman
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 41.02 seconds
stream load tsv: 460 seconds loaded 74807831229 Bytes, about 155 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 57 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select: 70.6 seconds inserted 10000000 Rows, about 141K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230703121702_clickbench_pr_171526.html

Copy link
Contributor

@zddr zddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 0da1bc7 into apache:master Jul 5, 2023
26 of 32 checks passed
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 5, 2023
xiaokang pushed a commit that referenced this pull request Jul 5, 2023
…missing (#21333)

Fix #20227, the implementation has some problems and can not catch event-missing-exception.
@dutyu dutyu deleted the fix-hms-event-missing branch September 16, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants