From 65f9290cdb7a82d03c7721b3d3f72f019486b2f0 Mon Sep 17 00:00:00 2001 From: daidai <2017501503@qq.com> Date: Tue, 8 Oct 2024 18:45:50 +0800 Subject: [PATCH] add comments --- be/src/vec/data_types/serde/data_type_serde.h | 1 + be/src/vec/exec/format/parquet/vparquet_group_reader.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/be/src/vec/data_types/serde/data_type_serde.h b/be/src/vec/data_types/serde/data_type_serde.h index 1cdc2f7c3ff7e5..46236faa926c6f 100644 --- a/be/src/vec/data_types/serde/data_type_serde.h +++ b/be/src/vec/data_types/serde/data_type_serde.h @@ -243,6 +243,7 @@ class DataTypeSerDe { virtual Status deserialize_column_from_fixed_json(IColumn& column, Slice& slice, int rows, int* num_deserialized, const FormatOptions& options) const { + //In this function implementation, we need to consider the case where rows is 0, 1, and other larger integers. if (rows < 1) [[unlikely]] { return Status::OK(); } diff --git a/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp b/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp index 08ecb601f39941..37e82774c39ee4 100644 --- a/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp +++ b/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp @@ -654,6 +654,7 @@ Status RowGroupReader::_fill_partition_columns( auto _text_serde = slot_desc->get_data_type_ptr()->get_serde(); Slice slice(value.data(), value.size()); int num_deserialized = 0; + // Be careful when reading empty rows from parquet row groups. if (_text_serde->deserialize_column_from_fixed_json(*col_ptr, slice, rows, &num_deserialized, _text_formatOptions) != Status::OK()) {