From 26b5725f0096539b63bec229ea024a9d32454163 Mon Sep 17 00:00:00 2001 From: eldenmoon <15605149486@163.com> Date: Wed, 20 Dec 2023 23:37:00 +0800 Subject: [PATCH] throw exception instead of CHECK --- be/src/vec/columns/column_object.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/be/src/vec/columns/column_object.cpp b/be/src/vec/columns/column_object.cpp index 3185952edfe4b2..f44fc62ed982ea 100644 --- a/be/src/vec/columns/column_object.cpp +++ b/be/src/vec/columns/column_object.cpp @@ -1161,8 +1161,14 @@ void ColumnObject::merge_sparse_to_root_column() { rapidjson::Writer writer(buffer); root.Accept(writer); bool res = parser.parse(buffer.GetString(), buffer.GetSize()); - CHECK(res) << "buffer:" << std::string(buffer.GetString(), buffer.GetSize()) - << ", row_num:" << i; + if (!res) { + throw Exception(ErrorCode::INVALID_ARGUMENT, + "parse json failed, doc: {}" + ", row_num:{}" + ", error:{}", + std::string(buffer.GetString(), buffer.GetSize()), i, + JsonbErrMsg::getErrMsg(parser.getErrorCode())); + } result_column_ptr->insert_data(parser.getWriter().getOutput()->getBuffer(), parser.getWriter().getOutput()->getSize()); result_column_nullable->get_null_map_data().push_back(0);