Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle config is broken #507

Open
jmalkin opened this issue Feb 14, 2024 · 1 comment
Open

Checkstyle config is broken #507

jmalkin opened this issue Feb 14, 2024 · 1 comment

Comments

@jmalkin
Copy link
Contributor

jmalkin commented Feb 14, 2024

When running checkstyle, there are two issues:

  • suppressions replies on undefined variable ${config_loc}
  • There is an exception: Caused by: java.lang.IllegalArgumentException: 'other' is different type of Path

I was able to remedy these to where I can now run it as
java -Dconfig_loc=tools -jar /opt/homebrew/Cellar/checkstyle/10.13.0/libexec/checkstyle-10.13.0-all.jar -c tools/SketchesCheckstyle.xml src
but even that required modifying the SketchesCheckstyle.xml to add a path to Checker's basedir in the config: https://github.com/apache/datasketches-java/blob/master/tools/SketchesCheckstyle.xml#L39

Maybe this runs in specific IDEs as-is, but we need to make sure we're not exploiting quirks of an IDE if we expect people to run this routinely.

@jmalkin
Copy link
Contributor Author

jmalkin commented Feb 14, 2024

Removing that basedir line entirely might work for that part, but doesn't solve the missing ${config_loc} issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant