Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This commit adds support for FDB Tenants to erlfdb, and I wanted to offer it for your consideration.
I used the source for the official FDB Python and Java clients as reference.
Further guidance needed
There are some decisions that will probably raise an eyebrow. They are:
get_empty_test
to use Tenants.API version
Tenant support exists in some version after 620, though I did not pinpoint it precisely. Presumably this would be a breaking change for anyone using a cluster with <= 620. Guidance is appreciated here.
Empty Unit Test
I almost got myself into a pickle by running unit tests using a real cluster file. Perhaps I should have known better, but I didn't expect the unit tests to run a full
clear_range
. (Especially given that the unit tests are set to run with a simplemake
command). Luckily, the cluster I used only contained dev data, so no harm done. However, this seemed like an opportunity to use tenants to conduct the test in a safe manner.