Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary profiles; use -Dtarget.name instead #263

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Conversation

sebbASF
Copy link
Contributor

@sebbASF sebbASF commented Oct 28, 2023

These profiles just clutter the pom.
in any case, they don't cover all possible target names

These profiles just clutter the pom.
in any case, they don't cover all possible target names
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #263 (770a959) into master (8962b46) will decrease coverage by 0.39%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
- Coverage     75.19%   74.80%   -0.39%     
+ Complexity      441      438       -3     
============================================
  Files            38       38              
  Lines          1818     1818              
  Branches        178      178              
============================================
- Hits           1367     1360       -7     
- Misses          341      348       +7     
  Partials        110      110              

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

No point running all the tests until the changes are sorted out

[skip ci]
[skip ci]
@sebbASF sebbASF marked this pull request as draft November 1, 2023 08:26
@sebbASF
Copy link
Contributor Author

sebbASF commented Nov 1, 2023

Looks like at least one profile may need an additional property override. See #264

@sebbASF
Copy link
Contributor Author

sebbASF commented Nov 1, 2023

It seems one may be able to automatically activate a profile based on a property.
If so, it should be possible to automatically change another property based on matching the value of target.name. To be investigated.

@sebbASF
Copy link
Contributor Author

sebbASF commented Nov 4, 2023

It does seem to be possible to detect a specific value of target.name and use that to define another property.

@sebbASF sebbASF marked this pull request as ready for review November 14, 2023 15:57
@sebbASF sebbASF merged commit 5d7f69d into master Nov 14, 2023
28 checks passed
@sebbASF sebbASF deleted the profiletidy branch November 14, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants