Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Mode fixes build. #260

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Import Mode fixes build. #260

merged 1 commit into from
Oct 27, 2023

Conversation

aremily
Copy link
Contributor

@aremily aremily commented Oct 27, 2023

The Mode import was removed in a previous commit, which broke the build. This PR reapplies the required imports.

@aremily
Copy link
Contributor Author

aremily commented Oct 27, 2023

buildlog.txt

@codecov-commenter
Copy link

Codecov Report

Merging #260 (83302b8) into master (5dd8e29) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #260   +/-   ##
=========================================
  Coverage     74.82%   74.82%           
  Complexity      439      439           
=========================================
  Files            38       38           
  Lines          1819     1819           
  Branches        178      178           
=========================================
  Hits           1361     1361           
  Misses          348      348           
  Partials        110      110           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebbASF
Copy link
Contributor

sebbASF commented Oct 27, 2023

I don't see evidence of a build failing because of a missing import?

@sebbASF sebbASF marked this pull request as draft October 27, 2023 08:22
@sebbASF sebbASF marked this pull request as ready for review October 27, 2023 10:44
@sebbASF
Copy link
Contributor

sebbASF commented Oct 27, 2023

I see now - these classes are not built by default

@sebbASF sebbASF merged commit 36394cd into apache:master Oct 27, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants