Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linstor: add support for ISO block devices and direct download #9792

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from
Open

Linstor: add support for ISO block devices and direct download #9792

wants to merge 2 commits into from

Conversation

rp-
Copy link
Contributor

@rp- rp- commented Oct 14, 2024

Description

This PR add KVM support for BLOCK driver ISO/CDROM devices and add support for Linstor to it.
It is usually only used with the "direct download" option on ISO templates.

Fixes: #9772

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Linstor hyper-converged cluster

How did you try to break this feature and the system with this change?

@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.89610% with 74 lines in your changes missing coverage. Please review.

Project coverage is 15.10%. Comparing base (a6cef7a) to head (9511e78).

Files with missing lines Patch % Lines
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java 0.00% 31 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 20 Missing ⚠️
...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 16.66% 10 Missing ⚠️
...ypervisor/kvm/resource/LibvirtDomainXMLParser.java 12.50% 7 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 3 Missing ⚠️
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9792      +/-   ##
============================================
- Coverage     15.11%   15.10%   -0.01%     
+ Complexity    11217    11214       -3     
============================================
  Files          5404     5404              
  Lines        473426   473468      +42     
  Branches      60681    61036     +355     
============================================
- Hits          71539    71533       -6     
- Misses       393891   393940      +49     
+ Partials       7996     7995       -1
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.82% <3.89%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sureshanaparti sureshanaparti added this to the 4.19.2.0 milestone Oct 15, 2024
sureshanaparti
sureshanaparti approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some refactor suggestions, overall code lgtm.

@rp- rp- force-pushed the linstor-4.19-iso-direct-download branch from d16841a to 44e2b4d Compare October 16, 2024 14:13
DaanHoogland
DaanHoogland approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

.../hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java Outdated Show resolved Hide resolved
...age/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java Outdated Show resolved Hide resolved
...age/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java Outdated Show resolved Hide resolved
@rp- rp- force-pushed the linstor-4.19-iso-direct-download branch from 44e2b4d to dc02baf Compare October 29, 2024 12:21
@rp-
Copy link
Contributor Author

rp- commented Oct 29, 2024

Did Daan's suggestions.

@rp- rp- force-pushed the linstor-4.19-iso-direct-download branch from dc02baf to 4e970b8 Compare October 31, 2024 07:30
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@rp- rp- force-pushed the linstor-4.19-iso-direct-download branch from 4e970b8 to d8b8ad5 Compare October 31, 2024 07:32
@rp-
Copy link
Contributor Author

rp- commented Oct 31, 2024

Just added a CHANGELOG.md entry no functional changes

@rp-
Copy link
Contributor Author

rp- commented Oct 31, 2024

@blueorangutan package

@blueorangutan
Copy link

@rp- a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11474

@DaanHoogland
Copy link
Contributor

@blueorangutan LLpackage

@blueorangutan
Copy link

@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6216

@DaanHoogland
Copy link
Contributor

@blueorangutan LLtest

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov
borisstoyanov approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, couldn't test it

@blueorangutan
Copy link

[LL]Trillian test result (tid-7041)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 58956 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9792-t7041-kvm-centos7.zip
Smoke tests completed. 85 look OK, 48 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestAddVmToSubDomain>:teardown Error 24.91 test_accounts.py
test_DeleteDomain Error 233.68 test_accounts.py
test_forceDeleteDomain Failure 331.75 test_accounts.py
test_forceDeleteDomain Error 331.75 test_accounts.py
test_01_events_resource Error 409.43 test_events_resource.py
test_01_events_resource Error 409.43 test_events_resource.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
test_deploy_more_vms_than_limit_allows Error 124.31 test_deploy_vms_in_parallel.py
test_deployvm_userconcentrated Error 34.37 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing Error 0.07 test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDomainsServiceOfferings>:teardown Error 381.31 test_domain_service_offerings.py
ContextSuite context=TestHostControlState>:teardown Error 47.42 test_host_control_state.py
ContextSuite context=TestImportAndUnmanageVolumes>:teardown Error 20.41 test_import_unmanage_volumes.py
test_01_invalid_upgrade_kubernetes_cluster Error 422.68 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Error 93.16 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Error 2.24 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Error 2.17 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Error 2.15 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 40.80 test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
ContextSuite context=TestListVolumes>:setup Error 0.00 test_list_volumes.py
test_list_vms_metrics_admin Error 31.90 test_metrics_api.py
test_list_vms_metrics_history Error 24.90 test_metrics_api.py
test_list_volumes_metrics_history Error 5.36 test_metrics_api.py
test_02_native_to_native_vpc_migration Error 4613.84 test_migration.py
ContextSuite context=TestNetworkMigration>:teardown Error 4614.02 test_migration.py
test_01_verify_ipv6_network Error 159.68 test_network_ipv6.py
test_01_verify_ipv6_network Error 159.69 test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser Error 201.82 test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown Error 3.34 test_network_permissions.py
ContextSuite context=TestPublicIP>:teardown Error 22.29 test_network.py
test_reboot_router Error 198.83 test_network.py
test_reboot_router Error 198.84 test_network.py
ContextSuite context=TestNonStrictAffinityGroups>:teardown Error 162.25 test_nonstrict_affinity_group.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:teardown Error 35.28 test_password_server.py
test_01_isolated_persistent_network Error 32.65 test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown Error 67.07 test_persistent_network.py
test_01_create_delete_portforwarding_fornonvpc Error 135.87 test_portforwardingrules.py
test_01_add_primary_storage_disabled_host Error 0.58 test_primary_storage.py
test_01_primary_storage_nfs Error 0.13 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.22 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.11 test_primary_storage_scope.py
test_09_project_suspend Error 79.06 test_projects.py
test_deploy_vm_with_registered_userdata Error 84.51 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow Error 77.68 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append Error 79.65 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params Error 78.57 test_register_userdata.py
test_01_reset_vm_on_reboot Error 8.10 test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:teardown Error 114.10 test_resource_accounting.py
test_01_restore_vm Error 0.04 test_restore_vm.py
test_02_restore_vm_allocated_root Error 0.03 test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:teardown Error 77.74 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:teardown Error 29.16 test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:teardown Error 59.56 test_router_dns.py
ContextSuite context=TestRouterDnsService>:teardown Error 39.72 test_router_dnsservice.py
test_01_single_VPC_iptables_policies Error 126.64 test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true Error 94.64 test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false Failure 99.23 test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false Error 99.23 test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Error 168.70 test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Error 305.02 test_routers_network_ops.py
test_03_RVR_Network_check_router_state Error 184.28 test_routers_network_ops.py
test_07_stop_router Error 3.57 test_routers.py
test_09_reboot_router Error 32.09 test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup Error 0.00 test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup Error 28.49 test_service_offerings.py
test_04_change_source_nat_ip_address_for_vpc Error 40.86 test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup Error 0.00 test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup Error 0.00 test_snapshots.py
test_05_stop_ssvm Error 4.36 test_ssvm.py
test_06_stop_cpvm Error 12.34 test_ssvm.py
test_09_reboot_ssvm_forced Error 13.39 test_ssvm.py
test_10_reboot_cpvm_forced Error 12.47 test_ssvm.py
test_02_deploy_vm_from_direct_download_template Error 5.83 test_templates.py
ContextSuite context=TestCreateTemplateWithDirectDownload>:teardown Error 20.17 test_templates.py
ContextSuite context=TestTemplates>:setup Error 31.41 test_templates.py
ContextSuite context=TestLBRuleUsage>:setup Error 37.97 test_usage.py
ContextSuite context=TestNatRuleUsage>:setup Error 45.17 test_usage.py
ContextSuite context=TestPublicIPUsage>:setup Error 52.34 test_usage.py
ContextSuite context=TestSnapshotUsage>:setup Error 58.50 test_usage.py
ContextSuite context=TestVmUsage>:setup Error 79.25 test_usage.py
ContextSuite context=TestVolumeUsage>:setup Error 85.48 test_usage.py
ContextSuite context=TestVpnUsage>:setup Error 91.80 test_usage.py
test_01_scale_up_verify Failure 35.04 test_vm_autoscaling.py
test_02_update_vmprofile_and_vmgroup Failure 245.43 test_vm_autoscaling.py
test_03_scale_down_verify Failure 304.36 test_vm_autoscaling.py
test_04_stop_remove_vm_in_vmgroup Failure 0.02 test_vm_autoscaling.py
test_06_autoscaling_vmgroup_on_project_network Error 3.66 test_vm_autoscaling.py
test_07_autoscaling_vmgroup_on_vpc_network Error 1.16 test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host Error 0.08 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 0.06 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 0.08 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 0.08 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 0.06 test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup Error 3.20 test_vm_life_cycle.py
test_04_deploy_vnf_appliance Error 97.84 test_vnf_templates.py
test_04_deploy_vnf_appliance Error 97.84 test_vnf_templates.py
test_05_delete_vnf_template Error 1.11 test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown Error 2.22 test_vnf_templates.py
test_02_attach_volume Error 71.46 test_volumes.py
test_03_download_attached_volume Error 6.21 test_volumes.py
test_03_download_attached_volume Error 6.22 test_volumes.py
test_04_delete_attached_volume Error 17.60 test_volumes.py
test_04_delete_attached_volume Error 17.60 test_volumes.py
test_05_detach_volume Error 12.43 test_volumes.py
test_05_detach_volume Error 12.43 test_volumes.py
test_06_download_detached_volume Error 15.08 test_volumes.py
test_06_download_detached_volume Error 15.08 test_volumes.py
test_08_resize_volume Error 59.57 test_volumes.py
test_08_resize_volume Error 59.57 test_volumes.py
test_09_delete_detached_volume Error 33.86 test_volumes.py
test_09_delete_detached_volume Error 33.86 test_volumes.py
test_10_list_volumes Error 12.68 test_volumes.py
test_11_attach_volume_with_unstarted_vm Error 13.14 test_volumes.py
test_11_attach_volume_with_unstarted_vm Error 13.14 test_volumes.py
test_12_resize_volume_with_only_size_parameter Error 2.16 test_volumes.py
test_12_resize_volume_with_only_size_parameter Error 2.16 test_volumes.py
test_13_migrate_volume_and_change_offering Error 8.55 test_volumes.py
test_13_migrate_volume_and_change_offering Error 8.55 test_volumes.py
ContextSuite context=TestVolumes>:teardown Error 9.61 test_volumes.py
test_01_verify_ipv6_vpc Error 64.10 test_vpc_ipv6.py
test_01_verify_ipv6_vpc Error 64.11 test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 71.56 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Failure 81.44 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 100.05 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Failure 69.85 test_vpc_redundant.py
test_05_rvpc_multi_tiers Failure 52.57 test_vpc_redundant.py
test_01_VPC_nics_after_destroy Error 212.21 test_vpc_router_nics.py
test_02_VPC_default_routes Failure 73.32 test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn Failure 154.59 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Failure 154.46 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Error 154.46 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 176.35 test_vpc_vpn.py
test_01_vpc_site2site_vpn Error 176.36 test_vpc_vpn.py

@apache apache deleted a comment from blueorangutan Nov 1, 2024
@apache apache deleted a comment from blueorangutan Nov 1, 2024
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11481

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11731)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 71490 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9792-t11731-kvm-ol8.zip
Smoke tests completed. 86 look OK, 47 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestAddVmToSubDomain>:teardown Error 26.24 test_accounts.py
test_DeleteDomain Error 181.77 test_accounts.py
test_forceDeleteDomain Failure 349.09 test_accounts.py
test_forceDeleteDomain Error 349.10 test_accounts.py
test_01_events_resource Error 410.75 test_events_resource.py
test_01_events_resource Error 410.77 test_events_resource.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
test_deploy_more_vms_than_limit_allows Error 105.25 test_deploy_vms_in_parallel.py
test_04_list_domains_level_filter Failure 0.04 test_list_domains.py
test_05_list_domains_no_filter Failure 0.02 test_list_domains.py
ContextSuite context=TestDomainsServiceOfferings>:teardown Error 294.25 test_domain_service_offerings.py
ContextSuite context=TestHostControlState>:teardown Error 32.54 test_host_control_state.py
ContextSuite context=TestImportAndUnmanageVolumes>:teardown Error 22.88 test_import_unmanage_volumes.py
test_01_invalid_upgrade_kubernetes_cluster Error 354.45 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Error 63.93 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Error 2.33 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Error 2.24 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Error 1.21 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 42.23 test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
ContextSuite context=TestListVolumes>:setup Error 0.00 test_list_volumes.py
test_list_vms_metrics_admin Error 31.72 test_metrics_api.py
test_list_vms_metrics_history Error 27.37 test_metrics_api.py
test_list_volumes_metrics_history Error 30.39 test_metrics_api.py
test_01_verify_ipv6_network Error 204.06 test_network_ipv6.py
test_01_verify_ipv6_network Error 204.08 test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser Error 206.74 test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown Error 6.63 test_network_permissions.py
ContextSuite context=TestPublicIP>:teardown Error 33.39 test_network.py
test_reboot_router Error 278.38 test_network.py
test_reboot_router Error 278.39 test_network.py
ContextSuite context=TestNonStrictAffinityGroups>:teardown Error 198.17 test_nonstrict_affinity_group.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:teardown Error 42.86 test_password_server.py
test_01_isolated_persistent_network Error 59.42 test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown Error 49.93 test_persistent_network.py
test_01_create_delete_portforwarding_fornonvpc Error 161.30 test_portforwardingrules.py
test_01_add_primary_storage_disabled_host Error 0.47 test_primary_storage.py
test_01_primary_storage_nfs Error 0.20 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.33 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.17 test_primary_storage_scope.py
test_09_project_suspend Error 81.95 test_projects.py
test_deploy_vm_with_registered_userdata Error 116.10 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow Error 144.26 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append Error 150.04 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params Error 103.77 test_register_userdata.py
test_01_reset_vm_on_reboot Error 5.22 test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:teardown Error 167.14 test_resource_accounting.py
test_01_restore_vm Error 0.05 test_restore_vm.py
test_02_restore_vm_allocated_root Error 0.05 test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:teardown Error 103.39 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:teardown Error 40.99 test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:teardown Error 23.16 test_router_dns.py
ContextSuite context=TestRouterDnsService>:teardown Error 37.63 test_router_dnsservice.py
test_01_single_VPC_iptables_policies Error 150.37 test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true Error 133.52 test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false Failure 107.91 test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false Error 107.91 test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Error 235.57 test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Error 255.34 test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Error 255.34 test_routers_network_ops.py
test_03_RVR_Network_check_router_state Error 256.59 test_routers_network_ops.py
test_07_stop_router Error 5.24 test_routers.py
test_09_reboot_router Error 27.81 test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup Error 0.00 test_service_offerings.py
test_04_change_offering_small Failure 7.24 test_service_offerings.py
test_05_disk_offering_strictness_true Error 1.38 test_service_offerings.py
test_06_disk_offering_strictness_false Error 1.37 test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup Error 0.00 test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup Error 0.00 test_snapshots.py
test_05_stop_ssvm Error 51.60 test_ssvm.py
test_06_stop_cpvm Error 21.81 test_ssvm.py
test_09_reboot_ssvm_forced Error 17.68 test_ssvm.py
test_10_reboot_cpvm_forced Error 22.79 test_ssvm.py
ContextSuite context=TestTemplates>:setup Error 115.53 test_templates.py
ContextSuite context=TestLBRuleUsage>:setup Error 20.51 test_usage.py
ContextSuite context=TestNatRuleUsage>:setup Error 123.10 test_usage.py
ContextSuite context=TestPublicIPUsage>:setup Error 150.57 test_usage.py
ContextSuite context=TestVmUsage>:setup Error 171.12 test_usage.py
ContextSuite context=TestVolumeUsage>:setup Error 181.12 test_usage.py
ContextSuite context=TestVpnUsage>:setup Error 191.38 test_usage.py
test_01_scale_up_verify Failure 35.05 test_vm_autoscaling.py
test_02_update_vmprofile_and_vmgroup Failure 245.67 test_vm_autoscaling.py
test_03_scale_down_verify Failure 304.60 test_vm_autoscaling.py
test_04_stop_remove_vm_in_vmgroup Failure 0.03 test_vm_autoscaling.py
test_06_autoscaling_vmgroup_on_project_network Failure 45.48 test_vm_autoscaling.py
test_06_autoscaling_vmgroup_on_project_network Error 45.49 test_vm_autoscaling.py
test_07_autoscaling_vmgroup_on_vpc_network Error 1.24 test_vm_autoscaling.py
ContextSuite context=TestVmAutoScaling>:teardown Error 12.33 test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host Error 0.09 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 13.64 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 30.13 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 0.15 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 9.56 test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup Error 0.00 test_vm_life_cycle.py
test_01_migrate_VM_and_root_volume Error 1.52 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 1.43 test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup Error 3.83 test_vm_life_cycle.py
ContextSuite context=TestVMSchedule>:setup Error 0.00 test_vm_schedule.py
test_04_deploy_vnf_appliance Error 312.26 test_vnf_templates.py
ContextSuite context=TestCreateVolume>:setup Error 0.00 test_volumes.py
test_01_root_volume_encryption Error 1.34 test_volumes.py
test_02_data_volume_encryption Error 1.33 test_volumes.py
test_03_root_and_data_volume_encryption Error 1.34 test_volumes.py
ContextSuite context=TestVolumes>:setup Error 44.34 test_volumes.py
test_01_verify_ipv6_vpc Error 8.56 test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Error 15.46 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Error 10.93 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Error 13.97 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 14.01 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 14.21 test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup Error 0.00 test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py

@rp- rp- force-pushed the linstor-4.19-iso-direct-download branch from d8b8ad5 to d17325d Compare November 4, 2024 14:33
@rp-
kvm-libvirtCR: fix == should be .equals errors
7f22d66
@rp-
linstor/kvm: add support for ISO block devices and direct download
9511e78 
If Linstor storage pool is used, use the BLOCK qemu driver for the
Linstor block device.

# Conflicts:
#	plugins/storage/volume/linstor/CHANGELOG.md
@rp- rp- force-pushed the linstor-4.19-iso-direct-download branch from d17325d to 9511e78 Compare November 4, 2024 14:35
@rp-
Copy link
Contributor Author

rp- commented Nov 4, 2024

@blueorangutan package

@blueorangutan
Copy link

@rp- a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11498

@rp-
Copy link
Contributor Author

rp- commented Nov 4, 2024

@blueorangutan test

2 similar comments
@DaanHoogland
Copy link
Contributor

@blueorangutan test

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11744)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49159 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9792-t11744-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@rp- rp- self-assigned this Nov 12, 2024
@rp- rp- linked an issue Nov 12, 2024 that may be closed by this pull request
bug: vm is not created for a direct download setup #9772
Open
@rp- rp- requested a review from slavkap November 12, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@slavkap slavkap Awaiting requested review from slavkap

Assignees

@rp- rp-

Labels
component:kvm component:primary-storage component:storage
Projects
None yet
Milestone
4.19.2
Development

Successfully merging this pull request may close these issues.

bug: vm is not created for a direct download setup
6 participants
@rp- @blueorangutan @DaanHoogland @sureshanaparti @borisstoyanov @slavkap