Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main build errors #9714

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix main build errors #9714

merged 1 commit into from
Sep 19, 2024

Conversation

JoaoJandre
Copy link
Contributor

Description

This PR fixes a build error introduced during the last merge with 4.19. Where a few loggers were left with their old names.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I ran the build script with: mvn clean install -T 4 -DskipTests -Dnoredist

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.81%. Comparing base (477beaf) to head (705bb95).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...com/cloud/hypervisor/vmware/util/VmwareHelper.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main    #9714       +/-   ##
============================================
+ Coverage     4.48%   15.81%   +11.33%     
- Complexity       0    12554    +12554     
============================================
  Files          392     5629     +5237     
  Lines        32154   492044   +459890     
  Branches      5672    63410    +57738     
============================================
+ Hits          1441    77820    +76379     
- Misses       30707   405904   +375197     
- Partials         6     8320     +8314     
Flag Coverage Δ
uitests 4.48% <ø> (ø)
unittests 16.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache weizhouapache merged commit a303c7c into apache:main Sep 19, 2024
25 checks passed
@weizhouapache
Copy link
Member

This happened many many time.

Now normally we build locally and then push to github after succesful build.

@JoaoJandre JoaoJandre deleted the fix-build-errors branch September 20, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants