Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: load project list with minimum details #9711

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rohityadavcloud
Copy link
Member

@rohityadavcloud rohityadavcloud commented Sep 19, 2024

This calls listProjects with details=min in the global header menu.

Stole idea/diff from @weizhouapache 's #9679 (comment) :)

Fixes #9679

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functional
  • ty)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

This calls listProjects with details=min in the global header menu.

Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud rohityadavcloud added this to the 4.19.2.0 milestone Sep 19, 2024
@weizhouapache
Copy link
Member

@blueorangutan ui

@rohityadavcloud
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.11%. Comparing base (0fae0c0) to head (fbef43a).
Report is 16 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9711      +/-   ##
============================================
+ Coverage     15.08%   15.11%   +0.02%     
+ Complexity    11194    11186       -8     
============================================
  Files          5406     5406              
  Lines        473184   473230      +46     
  Branches      58549    59732    +1183     
============================================
+ Hits          71398    71527     +129     
- Misses       393836   393899      +63     
+ Partials       7950     7804     -146     
Flag Coverage Δ
uitests 4.76% <ø> (+0.46%) ⬆️
unittests 15.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9711 (QA-JID-454)

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@DaanHoogland
Copy link
Contributor

tested in qa. @JoaoJandre are we still merging 4.19 bugfixes?

@JoaoJandre JoaoJandre merged commit 0a93dce into apache:4.19 Sep 20, 2024
25 checks passed
@DaanHoogland DaanHoogland deleted the faster-project-list-header branch September 20, 2024 14:40
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 14, 2024
This calls listProjects with details=min in the global header menu.

Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Dropdown in Dashboard takes minutes to load
5 participants