Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit run --all-files; fix end of file #9696

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

jbampton
Copy link
Member

Description

This PR fixes a pre-commit failure for end of files.

Seen here:

#9681

https://github.com/apache/cloudstack/actions/runs/10891026685/job/30240163645

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

pre-commit run --all-files

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.81%. Comparing base (a506bf1) to head (08e2a71).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9696      +/-   ##
============================================
- Coverage     15.81%   15.81%   -0.01%     
  Complexity    12554    12554              
============================================
  Files          5629     5629              
  Lines        492031   492031              
  Branches      62690    59772    -2918     
============================================
- Hits          77813    77811       -2     
- Misses       405895   405896       +1     
- Partials       8323     8324       +1     
Flag Coverage Δ
uitests 4.48% <ø> (ø)
unittests 16.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache weizhouapache merged commit 1d37ff2 into apache:main Sep 18, 2024
25 checks passed
@jbampton jbampton deleted the pre-commit-fix-end-of-file branch September 19, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants